fix: send exn for each recipient; no early return#311
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
==========================================
+ Coverage 83.70% 83.71% +0.01%
==========================================
Files 48 48
Lines 4270 4273 +3
Branches 1054 1067 +13
==========================================
+ Hits 3574 3577 +3
Misses 666 666
Partials 30 30 ☔ View full report in Codecov by Sentry. |
|
I had attempted to fix this ages ago in #273 and never got the chance to revisit. This doesn't work for end role auths as the notification won't appear unless they all sign the same exn, and putting individual member identifiers into each exn ( One approach might be to have a commitment on something internal to the exn and not the exn itself, but not sure how much that complicates other things. The approach I discussed with @lenkan before was setting the |
|
Technically, we can just set the |
345e664 to
74d4cb5
Compare
Fixes #310 . The existing code would return early rather than execute for each recipient. This was okay from a functional perspective because of how KERIA acts as a delivery service for EXN messages. Yet, the way the code is written it indicates the for loop would execute for each member of the array, which is not how the code works because it returns early.
KERIA would take the list of recipients in the EXN message and then deliver all EXN messages as declared.