optimize-movement-vector-normalization#610
Merged
Dreeam-qwq merged 4 commits intoWinds-Studio:ver/1.21.11from Feb 19, 2026
Merged
optimize-movement-vector-normalization#610Dreeam-qwq merged 4 commits intoWinds-Studio:ver/1.21.11from
Dreeam-qwq merged 4 commits intoWinds-Studio:ver/1.21.11from
Conversation
Dreeam-qwq
requested changes
Feb 5, 2026
leaf-server/minecraft-patches/features/0294-optimize-movement-vector-normalization.patch
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@Dreeam-qwq I finished it. |
Dreeam-qwq
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description: Optimize movement vector normalization
Summary
This PR optimizes the movement vector calculation by avoiding redundant
Math.min()andnormalize()operations when the squared length of the vector is already within known bounds.Problem
The previous implementation always calculated the scalar length and normalized the vector, even if the vector's length was already less than or equal to the maximum threshold ($8.0$ ). Since $\sqrt{x}$ ), performing it unnecessarily can impact performance in high-frequency movement logic.
vec3.length()involves a square root operation (Changes
I have replaced the unconditional normalization with a conditional check based on the squared length ():
vec3directly, skipping thelength(),normalize(), andscale()calls entirely.Impact