Modal headings and labels missing editor text color

[kushagra-goyal-14]

What?

Closes #50448
This PR updates the Modal Heading and Label text color value so that it matches with the text color used for other areas of the editor. Previously it was using color from wp-admin common.css.

Why?

How?

This PR is refreshes and is inspired from - #51246 and #50916

Testing Instructions

Open the WordPress block editor
Open the Preferences modal and check the colour value using Inspect Element.

Testing Instructions for Keyboard

Screenshots or screencast

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: kushagra-goyal-14 <kush123@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: ghorivipul97 <ghorivipul97@git.wordpress.org>
Co-authored-by: falgunihdesai <falgunihdesai@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[juanfra]

Thank you for working on this ✨

Looks good overall! I noticed that the h2 and h3 elements inside the modal aren’t picking up the correct color. I’m wondering if it might make sense to target the .components-modal__frame class to set the text color there, and also explicitly style h1, h2, and h3 within it to override the defaults coming from the common CSS.

modal-colors.mp4

[kushagra-goyal-14]

@juanfra I have updated the changes to target the .components-modal__frame class to set the text color there 🙌

[Mamaduka]

@kushagra-goyal-14, could you rebase this branch on top of the latest trunk. That should resolve CI checks.

[juanfra]

Thanks for working on this @kushagra-goyal-14! The code changes look good. Not sure if the comment before the color is a bit redundant.

Can you please be sure you sync trunk and rebase with the latest changes to fix the CI checks?