Skip to content

Replace nightly option with trunk. #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peterwilsoncc opened this issue Sep 13, 2024 · 4 comments · May be fixed by #2185
Open

Replace nightly option with trunk. #1763

peterwilsoncc opened this issue Sep 13, 2024 · 4 comments · May be fixed by #2185
Labels

Comments

@peterwilsoncc
Copy link
Contributor

The customize playground popover includes an option to run the nightly version of WordPress.

The action https://github.com/WordPress/wordpress-playground/actions/workflows/refresh-wordpress-nightly.yml pulls down the nightly each day and commits it to the repo and deploys (the action is currently failing but that's the idea at least). An example commit can be seen at 6be65fb

Screenshot 2024-09-14 at 9 30 12 AM

As the zip file is replaced each time, it has the effect of making the repo rather large.

Since #1705 and #1721 it's possible to run playground from trunk with a download from the WordPress/WordPress repository.

I propose the action for updating the nighly be removed and the dropdown be replaced with run trunk.

@adamziel
Copy link
Collaborator

I fully agree, excellent idea @peterwilsoncc

@peterwilsoncc
Copy link
Contributor Author

peterwilsoncc commented Sep 14, 2024

I tried to figure out how to do this without success sorry. Basically I couldn't figure out which file I should edit to update the version dropdown.

I could get it working by adding an option to the dropdown manually in this code block but that does not seem to be the correct approach.

{/*
* Without an empty option, React sometimes says
* the current selected version is "nightly" when
* `wp` is actually "6.4".
*/}
<option value="">-- Select a version --</option>
{Object.keys(supportedWPVersions).map(
(version) => (
<option key={version} value={version}>
WordPress{' '}
{supportedWPVersions[version]}
&nbsp;&nbsp;
</option>
)
)}

Nor was I clear on whether I needed to add a remote asset paths config.

@bgrgicak bgrgicak moved this from Inbox to Needs Triage/Our Reply in Playground Board Sep 27, 2024
@bgrgicak
Copy link
Collaborator

Here is a related Slack thread where the Test team wanted to use Playground for beta previews.

They ended up using this blueprint:

{
  "$schema": "https://playground.wordpress.net/blueprint-schema.json",
  "landingPage": "/wp-admin",
  "login": true,
  "preferredVersions": {
    "php": "7.4",
    "wp": "https://github-proxy.com/proxy/?repo=wordpress/wordpress"
  },
  "features": {
    "networking": true
  }
}

@bgrgicak
Copy link
Collaborator

@peterwilsoncc sorry for waiting so long on a reply, here are a few useful links in the Playground code in case you would like to work on it.

@bgrgicak bgrgicak moved this from Needs Triage/Our Reply to Needs Author's Reply in Playground Board Sep 30, 2024
@adamziel adamziel moved this from Needs Reply to Backlog in Playground Board Dec 18, 2024
@karthick-murugan karthick-murugan linked a pull request Apr 11, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants