Skip to content

Conversation

@Narzaal
Copy link

@Narzaal Narzaal commented Oct 20, 2025

Allow quality calculation for recipes when RequiredQuality > 0 but not expert

Problem

Recipes that cannot HQ ans is not expert have MaxQuality = 0, which allows crafts to finish even when RequiredQuality is not reached.

Fix

In RecipeData.cs:

  • Added Recipe.RequiredQuality > 0 to the condition that determines MaxQuality.
    This ensures such recipes have a valid MaxQuality value for quality calculations.

Impact

Allows quality progression and proper solver behavior on non-expert recipes with RequiredQuality.
No change for normal HQ recipes.

Allow quality calculation for recipes when RequiredQuality > 0 but not expert
@Narzaal
Copy link
Author

Narzaal commented Oct 20, 2025

I think Recipe.IsExpert was used to filter Recipe.RequiredQuality > 0. Perhaps Recipe.IsExpert should also be removed?

Before the new relic weapon, all recipes requiring quality were expert recipes, but now there are synthetic alpha, beta, and gamma dark matter recipes.

Now, the only recipes requiring quality are RequiredQuality > 0 or CanHq = true.
IsExpert can be in any of these cases, so all IsExpert = true require quality, but this is due to the two attributes RequiredQuality and CanHq. Leaving IsExpert active is acceptable; it won't break anything, so I left it in, but it's redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant