Pub/Sub links: distinguish bad channel based on centre-id #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkralidis
force-pushed
the
bad-channel-bad-centre-id
branch
from
24a5de8 to
01cc18b
Compare
tomkralidis
force-pushed
the
bad-channel-bad-centre-id
branch
from
01cc18b to
a9c0475
Compare
maaikelimper
requested changes
Jun 12, 2025
pywcmp/wcmp2/ets.py
Outdated
|
|
||
| if centre_id not in self.th.topics[3]: | ||
| status['code'] = 'FAILED' | ||
| status['message'] = 'Invalid WIS2 topic (bad centre-id) for Pub/Sub link channel' # noqa |
There was a problem hiding this comment.
use "unknown" instead of "bad"
status['message'] = 'Invalid WIS2 topic (unknown centre-id) for Pub/Sub link channel'
maaikelimper
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.