-
Notifications
You must be signed in to change notification settings - Fork 31
First pass at using puffin to display the query results #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sorry for the delay in review. Hoping to give this a spin by the end of the week! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good start, I think this is already plenty useful. Even if we figure out how to combine this into a single puffin connection, this mode of operation can still be quite useful imho!
Some docs are missing and I believe the frame processing should be slightly different. Details see comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apologies for the loooong delay and thanks for addressing all the comments, looking great now!
I added a changelog entry and a lil bit docs as well as some ci fixes (hopefully this comes back green now 🤞 )
Here's a first pass at a way to display the
GpuTimerQueryResult
in puffin. This only depends on the basepuffin
crate, notpuffin_egui
orpuffin_http
. I addedpuffin_http
as a dev dependency to the example since it's not as invasive of a change as usingegui
.This current approach assumes you use a different
puffin::GlobalProfiler
for wgpu than for CPU threads. I'm not the biggest fan of this approach, and I'd prefer to pretend that the WGPU Queue is just like any other CPU thread, and show them all in the same profiler window. However, the fact that we may need to wait several frames for timer results from the GPU makes this difficult.