Run ARM image build + CVE Scan + Test on ARM machines #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
qemu can be removed now can't it? |
Depends, if the platform matches the runner arch yes. Otherwise no. But I also want to turn this into a reusable work flow, and since I build the same platforms as the upstream image it needs to be dynamic. And I'm also working on building in qemu on my own runner images so I should do an check if it's already there or not |
|
@bendavies Also I want to merge #20 before finishing this one |
WyriHaximus
force-pushed
the
Run-ARM-image-build-+-CVE-Scan-+-Test-on-ARM-machines
branch
3 times, most recently
from
55e527d to
d8a2df2
Compare
WyriHaximus
commented
Mar 8, 2025
| images: ${{ env.REGISTRY_IMAGE }} | ||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@v3 | ||
| if: ${{ !contains(matrix.platform, 'arm') && !contains(matrix.platform, 'amd64') }} |
There was a problem hiding this comment.
@bendavies As you suggested, not installing QEMU during runs when the image we're building is for arm64 or amd64. But still installing it for others, which will be never in for this image, unless the upstream image starts supporting more platforms
WyriHaximus
force-pushed
the
Run-ARM-image-build-+-CVE-Scan-+-Test-on-ARM-machines
branch
from
d8a2df2 to
733c8db
Compare
WyriHaximus
deleted the
Run-ARM-image-build-+-CVE-Scan-+-Test-on-ARM-machines
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.