fix: Match ledger_entry error codes with rippled #2549
Conversation
emreariyurek
force-pushed
the
emre_2540_match_ledger_entry_error_codes
branch
from
336e2d3 to
a0d827c
Compare
|
|
||
| if (input.index) { | ||
| key = ripple::uint256{std::string_view(*(input.index))}; | ||
| if (key.isZero()) |
There was a problem hiding this comment.
Can you please tell me where this came from? is that something they changed on rippled side too or was it missing all along in Clio?
There was a problem hiding this comment.
It comes from rippled side - PR5237
|
As @emreariyurek suggested (and is evident from failing CI) this requires a newer libXRPL than what we currently have. Putting this on hold till then. |
|
@godexsoft @emreariyurek Ah, so I just checked. The PR to update ledger entry error codes is not included in libxrpl 2.6.1, we can move this to next release of clio 👍 |
There was a problem hiding this comment.
Thanks for doing this task @emreariyurek ! Just one quick comment on my side
| if (!ledgerObject || ledgerObject->empty()) { | ||
| if (not input.includeDeleted) | ||
| return Error{Status{ClioError::RpcEntryNotFound}}; | ||
| return Error{Status{RippledError::rpcENTRY_NOT_FOUND}}; |
There was a problem hiding this comment.
Since Rippled has its own error code now, would you mind changing ClioError::RpcEntryNotFound to RippledError::rpcENTRY_NOT_FOUND, in all parts of clio and removing the Clio error code completely? Or feel free to create another issue for this. Thanks! 😃
There was a problem hiding this comment.
Done here: #2661
Yeah, that was expected since this was not in the beta nor in the rc we tried with.. next release it is 👍 |
4 participants
Fix #2540
Precondition: Ensure that the changes from 2540 are applied to xrpl.