Skip to content

Commit 6b942b9

Browse files
authored
rename nft sell offer flag (#377)
* rename nft sell offer flag
1 parent 820d5c1 commit 6b942b9

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

tests/unit/models/transactions/test_nftoken_create_offer.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def test_nftoken_sell_offer_with_zero_amount(self):
5151
sequence=_SEQUENCE,
5252
amount="0",
5353
nftoken_id=_NFTOKEN_ID,
54-
flags=[NFTokenCreateOfferFlag.TF_SELL_TOKEN],
54+
flags=[NFTokenCreateOfferFlag.TF_SELL_NFTOKEN],
5555
)
5656
self.assertTrue(tx.is_valid())
5757

@@ -62,7 +62,7 @@ def test_nftoken_sell_offer_with_positive_amount(self):
6262
sequence=_SEQUENCE,
6363
amount="1",
6464
nftoken_id=_NFTOKEN_ID,
65-
flags=[NFTokenCreateOfferFlag.TF_SELL_TOKEN],
65+
flags=[NFTokenCreateOfferFlag.TF_SELL_NFTOKEN],
6666
)
6767
self.assertTrue(tx.is_valid())
6868

@@ -107,6 +107,6 @@ def test_nftoken_sell_offer_with_owner(self):
107107
fee=_FEE,
108108
sequence=_SEQUENCE,
109109
amount="1",
110-
flags=[NFTokenCreateOfferFlag.TF_SELL_TOKEN],
110+
flags=[NFTokenCreateOfferFlag.TF_SELL_NFTOKEN],
111111
nftoken_id=_NFTOKEN_ID,
112112
)

xrpl/models/transactions/nftoken_create_offer.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
class NFTokenCreateOfferFlag(int, Enum):
1717
"""Transaction Flags for an NFTokenCreateOffer Transaction."""
1818

19-
TF_SELL_TOKEN = 0x00000001
19+
TF_SELL_NFTOKEN = 0x00000001
2020
"""
2121
If set, indicates that the offer is a sell offer.
2222
Otherwise, it is a buy offer.
@@ -26,7 +26,7 @@ class NFTokenCreateOfferFlag(int, Enum):
2626
class NFTokenCreateOfferFlagInterface(FlagInterface):
2727
"""Transaction Flags for an NFTokenCreateOffer Transaction."""
2828

29-
TF_SELL_TOKEN: bool
29+
TF_SELL_NFTOKEN: bool
3030

3131

3232
@require_kwargs_on_init
@@ -107,7 +107,7 @@ def _get_errors(self: NFTokenCreateOffer) -> Dict[str, str]:
107107

108108
def _get_amount_error(self: NFTokenCreateOffer) -> Optional[str]:
109109
if (
110-
not self.has_flag(NFTokenCreateOfferFlag.TF_SELL_TOKEN)
110+
not self.has_flag(NFTokenCreateOfferFlag.TF_SELL_NFTOKEN)
111111
and get_amount_value(self.amount) <= 0
112112
):
113113
return "Must be greater than 0 for a buy offer"
@@ -120,12 +120,12 @@ def _get_destination_error(self: NFTokenCreateOffer) -> Optional[str]:
120120

121121
def _get_owner_error(self: NFTokenCreateOffer) -> Optional[str]:
122122
if (
123-
not self.has_flag(NFTokenCreateOfferFlag.TF_SELL_TOKEN)
123+
not self.has_flag(NFTokenCreateOfferFlag.TF_SELL_NFTOKEN)
124124
and self.owner is None
125125
):
126126
return "Must be present for buy offers"
127127
if (
128-
self.has_flag(NFTokenCreateOfferFlag.TF_SELL_TOKEN)
128+
self.has_flag(NFTokenCreateOfferFlag.TF_SELL_NFTOKEN)
129129
and self.owner is not None
130130
):
131131
return "Must not be present for sell offers"

0 commit comments

Comments
 (0)