From 0974c3aa1a1e157c8456d18d487b6f59c86d69d9 Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Wed, 15 May 2024 16:09:17 -0400 Subject: [PATCH 01/13] add node 22 support --- .github/workflows/nodejs.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index d996daf125..91ab4a2a41 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -60,7 +60,7 @@ jobs: strategy: matrix: - node-version: [16.x, 18.x, 20.x] + node-version: [16.x, 18.x, 20.x, 22.x] steps: - uses: actions/checkout@v3 @@ -101,7 +101,7 @@ jobs: strategy: matrix: - node-version: [16.x, 18.x, 20.x] + node-version: [16.x, 18.x, 20.x, 22.x] steps: - uses: actions/checkout@v3 @@ -205,7 +205,7 @@ jobs: strategy: matrix: - node-version: [16.x, 18.x, 20.x] + node-version: [16.x, 18.x, 20.x, 22.x] steps: - uses: actions/checkout@v3 From ed5b4002306ed99d1c9dbd670fa52b5cf1344250 Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Wed, 15 May 2024 16:20:35 -0400 Subject: [PATCH 02/13] add debug stuff --- .github/workflows/nodejs.yml | 5 ----- packages/ripple-keypairs/package.json | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 91ab4a2a41..1a97c790fd 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -45,7 +45,6 @@ jobs: key: ${{ runner.os }}-deps-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }} restore-keys: | ${{ runner.os }}-deps-${{ matrix.node-version }}- - ${{ runner.os }}-deps- - name: Install Dependencies if: steps.cache-nodemodules.outputs.cache-hit != 'true' @@ -86,7 +85,6 @@ jobs: key: ${{ runner.os }}-deps-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }} restore-keys: | ${{ runner.os }}-deps-${{ matrix.node-version }}- - ${{ runner.os }}-deps- - name: Install Dependencies if: steps.cache-nodemodules.outputs.cache-hit != 'true' @@ -132,7 +130,6 @@ jobs: key: ${{ runner.os }}-deps-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }} restore-keys: | ${{ runner.os }}-deps-${{ matrix.node-version }}- - ${{ runner.os }}-deps- - name: Install Dependencies if: steps.cache-nodemodules.outputs.cache-hit != 'true' @@ -184,7 +181,6 @@ jobs: key: ${{ runner.os }}-deps-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }} restore-keys: | ${{ runner.os }}-deps-${{ matrix.node-version }}- - ${{ runner.os }}-deps- - name: Install Dependencies if: steps.cache-nodemodules.outputs.cache-hit != 'true' @@ -231,7 +227,6 @@ jobs: key: ${{ runner.os }}-deps-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }} restore-keys: | ${{ runner.os }}-deps-${{ matrix.node-version }}- - ${{ runner.os }}-deps- - name: Install Dependencies if: steps.cache-nodemodules.outputs.cache-hit != 'true' diff --git a/packages/ripple-keypairs/package.json b/packages/ripple-keypairs/package.json index f66e1287bd..def2df54bc 100644 --- a/packages/ripple-keypairs/package.json +++ b/packages/ripple-keypairs/package.json @@ -3,7 +3,7 @@ "version": "2.0.0", "description": "Cryptographic key pairs for the XRP Ledger", "scripts": { - "build": "tsc --build tsconfig.build.json", + "build": "tsc --build tsconfig.build.json --verbose", "test": "jest --verbose false --silent=false ./test/*.test.ts", "test:browser": "npm run build && karma start ./karma.config.js", "clean": "rm -rf ./dist ./coverage ./test/testCompiledForWeb tsconfig.build.tsbuildinfo", From ad2960684b915e72741865e9e4be15a0c958be2b Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Wed, 15 May 2024 16:35:32 -0400 Subject: [PATCH 03/13] try upgrading npm --- .github/workflows/nodejs.yml | 20 ++++++++++---------- package.json | 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 1a97c790fd..f427da6308 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -28,9 +28,9 @@ jobs: with: node-version: ${{ matrix.node-version }} - - name: Setup npm version 9 + - name: Setup npm version 10 run: | - npm i -g npm@9 --registry=https://registry.npmjs.org + npm i -g npm@10 --registry=https://registry.npmjs.org - name: Cache node modules id: cache-nodemodules @@ -68,9 +68,9 @@ jobs: with: node-version: ${{ matrix.node-version }} - - name: Setup npm version 9 + - name: Setup npm version 10 run: | - npm i -g npm@9 --registry=https://registry.npmjs.org + npm i -g npm@10 --registry=https://registry.npmjs.org - name: Cache node modules id: cache-nodemodules @@ -113,9 +113,9 @@ jobs: with: node-version: ${{ matrix.node-version }} - - name: Setup npm version 9 + - name: Setup npm version 10 run: | - npm i -g npm@9 --registry=https://registry.npmjs.org + npm i -g npm@10 --registry=https://registry.npmjs.org - name: Cache node modules id: cache-nodemodules @@ -164,9 +164,9 @@ jobs: run: | docker run --detach --rm --name rippled-service -p 6006:6006 --volume "${{ github.workspace }}/.ci-config/":"/opt/ripple/etc/" --health-cmd="wget localhost:6006 || exit 1" --health-interval=5s --health-retries=10 --health-timeout=2s --env GITHUB_ACTIONS=true --env CI=true ${{ env.RIPPLED_DOCKER_IMAGE }} /opt/ripple/bin/rippled -a --conf /opt/ripple/etc/rippled.cfg - - name: Setup npm version 9 + - name: Setup npm version 10 run: | - npm i -g npm@9 --registry=https://registry.npmjs.org + npm i -g npm@10 --registry=https://registry.npmjs.org - name: Cache node modules id: cache-nodemodules @@ -210,9 +210,9 @@ jobs: with: node-version: ${{ matrix.node-version }} - - name: Setup npm version 9 + - name: Setup npm version 10 run: | - npm i -g npm@9 --registry=https://registry.npmjs.org + npm i -g npm@10 --registry=https://registry.npmjs.org - name: Cache node modules id: cache-nodemodules diff --git a/package.json b/package.json index 2e55b4071e..0c4cf3e452 100644 --- a/package.json +++ b/package.json @@ -65,6 +65,6 @@ ], "engines": { "node": ">=16.0.0", - "npm": ">=7.10.0 < 10.0.0" + "npm": ">=7.10.0 < 11.0.0" } } From cea1812d15db5fbb0e2cb983c2a972f055cb8a55 Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Wed, 15 May 2024 16:38:14 -0400 Subject: [PATCH 04/13] remove node 16 --- .github/workflows/nodejs.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index f427da6308..916c4fbb2c 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -19,7 +19,7 @@ jobs: strategy: matrix: - node-version: [16.x] + node-version: [18.x] steps: - uses: actions/checkout@v3 @@ -59,7 +59,7 @@ jobs: strategy: matrix: - node-version: [16.x, 18.x, 20.x, 22.x] + node-version: [18.x, 20.x, 22.x] steps: - uses: actions/checkout@v3 @@ -99,7 +99,7 @@ jobs: strategy: matrix: - node-version: [16.x, 18.x, 20.x, 22.x] + node-version: [18.x, 20.x, 22.x] steps: - uses: actions/checkout@v3 @@ -150,7 +150,7 @@ jobs: strategy: matrix: - node-version: [16.x] + node-version: [18.x] steps: - uses: actions/checkout@v3 @@ -201,7 +201,7 @@ jobs: strategy: matrix: - node-version: [16.x, 18.x, 20.x, 22.x] + node-version: [18.x, 20.x, 22.x] steps: - uses: actions/checkout@v3 From 709f71f9a99264a567c122a2588d1bc3d05ce286 Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Wed, 15 May 2024 16:42:16 -0400 Subject: [PATCH 05/13] debug --- .github/workflows/nodejs.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 916c4fbb2c..b6ec079277 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -90,8 +90,11 @@ jobs: if: steps.cache-nodemodules.outputs.cache-hit != 'true' run: npm ci - - run: npm run build - - run: npm test + - name: Setup tmate session + uses: mxschmitt/action-tmate@v3 + + # - run: npm run build + # - run: npm test integration: runs-on: ubuntu-latest From 7e6df39d211d1bef1efde524e5861318d666f991 Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Thu, 11 Jul 2024 15:18:38 -0400 Subject: [PATCH 06/13] remove tmux --- .github/workflows/nodejs.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 971da96507..7227fbd8c4 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -90,8 +90,8 @@ jobs: if: steps.cache-nodemodules.outputs.cache-hit != 'true' run: npm ci - - name: Setup tmate session - uses: mxschmitt/action-tmate@v3 + # - name: Setup tmate session + # uses: mxschmitt/action-tmate@v3 # - run: npm run build # - run: npm test From 76d3cdf929a297bdb706b257cfad7998203e077f Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Fri, 11 Oct 2024 10:05:18 -0700 Subject: [PATCH 07/13] only allow 22.9 onwards --- package-lock.json | 4 ++-- package.json | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package-lock.json b/package-lock.json index 80a0248ae3..d3f65813db 100644 --- a/package-lock.json +++ b/package-lock.json @@ -56,8 +56,8 @@ "webpack-cli": "^5.0.1" }, "engines": { - "node": ">=18.0.0", - "npm": ">=7.10.0 < 10.0.0" + "node": ">=18.0.0 <22.0.0 || >=22.9.0", + "npm": ">=7.10.0" } }, "node_modules/@aashutoshrathi/word-wrap": { diff --git a/package.json b/package.json index 6ebdfcb55a..f455973759 100644 --- a/package.json +++ b/package.json @@ -64,7 +64,7 @@ "./packages/*" ], "engines": { - "node": ">=18.0.0", - "npm": ">=7.10.0 < 11.0.0" + "node": ">=18.0.0 <22.0.0 || >=22.9.0", + "npm": ">=7.10.0" } } From 7cff7234fe7b0712aa3ea7f75d215d9604329fbc Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Fri, 11 Oct 2024 10:13:05 -0700 Subject: [PATCH 08/13] try 22.8 --- .github/workflows/nodejs.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 7227fbd8c4..8cf0874d63 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -59,7 +59,7 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x, 22.x] + node-version: [18.x, 20.x, "22.8"] steps: - uses: actions/checkout@v3 @@ -102,7 +102,7 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x, 22.x] + node-version: [18.x, 20.x, "22.8"] steps: - uses: actions/checkout@v3 @@ -204,7 +204,7 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x, 22.x] + node-version: [18.x, 20.x, "22.8"] steps: - uses: actions/checkout@v3 From 942243d15044c0edfc1adc92c815788e833a94ff Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Fri, 11 Oct 2024 10:19:38 -0700 Subject: [PATCH 09/13] try 22.7 --- .github/workflows/nodejs.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 8cf0874d63..2358e779a4 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -59,7 +59,7 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x, "22.8"] + node-version: [18.x, 20.x, "22.7"] steps: - uses: actions/checkout@v3 @@ -102,7 +102,7 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x, "22.8"] + node-version: [18.x, 20.x, "22.7"] steps: - uses: actions/checkout@v3 @@ -204,7 +204,7 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x, "22.8"] + node-version: [18.x, 20.x, "22.7"] steps: - uses: actions/checkout@v3 From 20117c941fb6fdd0572c1bad1cd47ce3e586d008 Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Fri, 11 Oct 2024 10:27:09 -0700 Subject: [PATCH 10/13] test more 22.x versions --- .github/workflows/nodejs.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 2358e779a4..190105c5c2 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -102,7 +102,7 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x, "22.7"] + node-version: [18.x, 20.x, "22.3"] steps: - uses: actions/checkout@v3 @@ -204,7 +204,7 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x, "22.7"] + node-version: [18.x, 20.x, "22.5"] steps: - uses: actions/checkout@v3 From 26928c5164200fc53937c016df87194589d44896 Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Fri, 11 Oct 2024 10:35:49 -0700 Subject: [PATCH 11/13] test more versions --- .github/workflows/nodejs.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 190105c5c2..b1ec0287cc 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -102,7 +102,7 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x, "22.3"] + node-version: [18.x, 20.x, "22.0"] steps: - uses: actions/checkout@v3 @@ -204,7 +204,7 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x, "22.5"] + node-version: [18.x, 20.x, "22.1"] steps: - uses: actions/checkout@v3 From 5aafe0b641d22b8ec8adea6a749ba1945f37257a Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Fri, 11 Oct 2024 10:43:10 -0700 Subject: [PATCH 12/13] switch back to 22.x, clean up --- .github/workflows/nodejs.yml | 13 +++++-------- package-lock.json | 2 +- package.json | 2 +- packages/ripple-keypairs/package.json | 2 +- 4 files changed, 8 insertions(+), 11 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index b1ec0287cc..4764983470 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -59,7 +59,7 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x, "22.7"] + node-version: [18.x, 20.x, 22.x] steps: - uses: actions/checkout@v3 @@ -90,11 +90,8 @@ jobs: if: steps.cache-nodemodules.outputs.cache-hit != 'true' run: npm ci - # - name: Setup tmate session - # uses: mxschmitt/action-tmate@v3 - - # - run: npm run build - # - run: npm test + - run: npm run build + - run: npm test integration: runs-on: ubuntu-latest @@ -102,7 +99,7 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x, "22.0"] + node-version: [18.x, 20.x, 22.x] steps: - uses: actions/checkout@v3 @@ -204,7 +201,7 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x, "22.1"] + node-version: [18.x, 20.x, 22.x] steps: - uses: actions/checkout@v3 diff --git a/package-lock.json b/package-lock.json index 1b9dced6ee..c0e1ac2bca 100644 --- a/package-lock.json +++ b/package-lock.json @@ -56,7 +56,7 @@ "webpack-cli": "^5.0.1" }, "engines": { - "node": ">=18.0.0 <22.0.0 || >=22.9.0", + "node": ">=18.0.0", "npm": ">=7.10.0" } }, diff --git a/package.json b/package.json index f455973759..70e36266a0 100644 --- a/package.json +++ b/package.json @@ -64,7 +64,7 @@ "./packages/*" ], "engines": { - "node": ">=18.0.0 <22.0.0 || >=22.9.0", + "node": ">=18.0.0", "npm": ">=7.10.0" } } diff --git a/packages/ripple-keypairs/package.json b/packages/ripple-keypairs/package.json index e316573058..b5899b1f50 100644 --- a/packages/ripple-keypairs/package.json +++ b/packages/ripple-keypairs/package.json @@ -3,7 +3,7 @@ "version": "2.0.0", "description": "Cryptographic key pairs for the XRP Ledger", "scripts": { - "build": "tsc --build tsconfig.build.json --verbose", + "build": "tsc --build tsconfig.build.json", "test": "jest --verbose false --silent=false ./test/*.test.ts", "test:browser": "npm run build && karma start ./karma.config.js", "clean": "rm -rf ./dist ./coverage ./test/testCompiledForWeb tsconfig.build.tsbuildinfo", From 6995f3e47c602a13a4f43551782423e586687f66 Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Fri, 11 Oct 2024 10:55:27 -0700 Subject: [PATCH 13/13] update README --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b9c031482b..aefb3169a7 100644 --- a/README.md +++ b/README.md @@ -25,7 +25,7 @@ All of which works in Node.js (tested for v18+) & web browsers (tested for Chrom ### Requirements -+ **[Node.js v18](https://nodejs.org/)** is recommended. We also support v20. Other versions may work but are not frequently tested. ++ **[Node.js v18](https://nodejs.org/)** is recommended. We also support v20 and v22. Other versions may work but are not frequently tested. ### Installing xrpl.js