build(deps-dev): bump eslint from 8.57.1 to 9.22.0 #2924
Conversation
dependabot
bot
added
the
dependencies
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/eslint-9.22.0
branch
2 times, most recently
from
6ebe305 to
2b39dc6
Compare
|
I'd like to hear the opinions of other members regarding the choice of style-guide.
We have three choices -- Define all the rules ourselves manually, use the "recommended" ESLint rulesets (or) indefinitely delay this upgrade to ESLint v9. I have implemented the second option for two packages in this PR. However, it comes with significant linter-upgrades across the packages. I have not fixed these linter warnings and errors. Before we invest any more effort in this direction, I'd like to hear the opinions of other developers. |
|
My thoughts regarding the previous msg: Alternative-1: Using the ESLint:recommended setting is the best way forward. At the moment, we depend on the airbnb javascript style guide. Both airbnb and google-'s javascript style guide are not maintained frequently. We can sever our dependencies on external style guides. Cons: This need developer time (I expect 1 week for 2 engineers). We need to migrate the codebase toward the new linter rules. Alternative-2: At the same time, linters are not critical functionality. xrpl.js software will work correctly, even if we don't use the latest linters. We can afford to wait for a few more years (!?) to upgrade the linter. Cons: This PR is already 10 files in diff. A future migration will need a lot more developer effort. We will effectively be kicking the ball down the road. |
@ckeshava ESLint v9 doesn’t bring any major functional improvements—its biggest change is the shift to the flat config system, which mainly affects configuration structure rather than linting capabilities. It's better to keep using ESlint v8 and indefinitely delay this upgrade. |
|
@khancode I'm fine with that choice. I'd like to invite @achowdhry-ripple 's thoughts here. He had remarked that the upgrade of the VHS code base was hinging on an upgrade of this javascript style guide. @achowdhry-ripple -- Would you be able to upgrade VHS to Node v18 without these changes? |
|
A newer version of eslint exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot recreate |
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.1 to 9.22.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.57.1...v9.22.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/eslint-9.22.0
branch
from
0ad3039 to
e994e10
Compare
|
Superseded by #3078. |
Bumps eslint from 8.57.1 to 9.22.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Changelog
Sourced from eslint's changelog.
... (truncated)
Commits
60a78e79.22.0d11fc14Build: changelog update for 9.22.097f788bchore: upgrade@eslint/js@9.22.0 (#19489)eed409achore: package.json update for@eslint/jsreleasef9a56d3chore: upgrade eslint-scope@8.3.0 (#19488)7ddb095feat: Export defineConfig, globalIgnores (#19487)86c5f37docs: Update README19c0127fix: improve message forno-consolesuggestions (#19483)fbdeff0docs: Update READMEc9e8510docs: generate deprecation notice in TSDoc comments from rule metadata (#19461)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)