Skip to content

Conversation

@mvadari
Copy link
Collaborator

@mvadari mvadari commented Mar 11, 2025

High Level Overview of Change

Adds xrpl.js support for Smart Escrows.

Also reorganizes the Escrow integration tests into one file.

Context of Change

XRPLF/XRPL-Standards#270

Type of Change

  • New feature (non-breaking change which adds functionality)

Did you update CHANGELOG.md?

  • Yes
  • No, this change does not impact library users

Test Plan

Added some basic tests

Integration tests expected to fail right now, since this is a new feature.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch smart-escrows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mvadari mvadari changed the title add basic support [DO NOT MERGE] Smart Escrows Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants