-
Notifications
You must be signed in to change notification settings - Fork 560
remove snippets files #3054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove snippets files #3054
Conversation
WalkthroughThis change removes the entire XRPL code snippets subsystem, including all TypeScript snippet example files, related documentation, TypeScript configuration, ESLint and build script overrides, and the associated GitHub Actions workflow job. All snippet-related scripts and references are eliminated from the package configuration and tooling. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~15 minutes
Possibly related PRs
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
packages/xrpl/HISTORY.md
Outdated
| * Fail faster on `tem` errors with `submitAndWait` | ||
| * Improved type-checking in models | ||
| * Fix issue with some transactions that would crash in validation | ||
| * Code snippets are removed from the xrpl.js client library. They have been [moved to a different location](https://github.com/XRPLF/xrpl-dev-portal/tree/master/_code-samples). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't need to go in the HISTORY, since it won't affect downstream library users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it won't affect users. However, if somebody comes around looking for these snippets in xrpl.js, shouldn't we direct them to the correct location?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README is a better place for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme already contains a link to the code samples: https://github.com/XRPLF/xrpl.js/blame/7799528961618eb5af8cb1f0847e9066d95c57b8/README.md#L114
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change reverted in 62b0e71
This reverts commit 0744d0d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
High Level Overview of Change
This PR aims to remove snippets-related files from the javascript client library. These files have been migrated to a new location.
Type of Change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (non-breaking change that only restructures code)
This PR aims to remove code, no new features are added.
Tests (You added tests for code that already exists, or your new feature included in this PR)
Documentation Updates
Release
Did you update HISTORY.md?
This change does not affect external API. However, for the sake of transparent communication, the note in the Changelog will be helpful.
Test Plan
The Github Actions CI will be updated. The mandatory run of snippets CI is no longer necessary. No new tests are added.