-
Notifications
You must be signed in to change notification settings - Fork 559
update slack message/add version tag for owsap project #3110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughModified the GitHub Actions release workflow to enable automatic SBOM project creation with configurable names and versions instead of fixed project IDs, updated the security review Slack notification channel, and simplified the release job step naming. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/release.yml (1)
501-501
: Slack channel correctly updated for security team review.The change correctly targets the security team notification to
#ripplex-security
while preserving#xrpl-js
for dev team and release notifications. This intentional separation of concerns aligns well with the PR objectives.Ensure that the
#ripplex-security
Slack channel exists, is monitored by the intended security team, and has appropriate permissions for the Slack bot user.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release.yml
(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: browser (24.x)
- GitHub Check: integration (24.x)
- GitHub Check: unit (20.x)
- GitHub Check: unit (22.x)
- GitHub Check: integration (20.x)
- GitHub Check: integration (22.x)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (2)
.github/workflows/release.yml (2)
524-524
: Release job name simplified.The job name is now more concise and readable without the "Pipeline" prefix. No functional impact.
206-208
: Verify the per-version project model aligns with your vulnerability tracking strategy.The code change replaces a fixed project ID with auto-creation using
projectName
andprojectVersion
. The OWASP Dependency-Track API v1 /api/v1/bom endpoint fully supports these parameters (projectName
,projectVersion
,autoCreate
), so this is a valid technical implementation.This shifts from updating a single managed OWASP project to creating a new project for each release version. Confirm this aligns with:
- How you track and retain vulnerability data across releases
- Any existing project organization or reporting workflows in OWASP
High Level Overview of Change
update slack channel for infosec review message
add version tag for owsap dependency tracking project
Context of Change
Type of Change
Did you update HISTORY.md?
Test Plan