Added missing nft_offer enum (#541) #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

psy2848048 wants to merge 1 commit into XRPLF:main from girin-app:feat/nft

psy2848048 commented Jul 24, 2024

Background

Try to resolve Querying nft_offer of account object feature request #541
NfTokenOfferObject class is already implmented. Only one option of the enum is missing

Contents

Added missing enum value nft_offer
Implemented its JSON parsing test

psy2848048 requested review from nhartner, nkramer44 and sappenin as code owners

July 24, 2024 03:51

nkramer44 self-assigned this


          fix: added missing nft_offer enum

d4af50e

psy2848048 force-pushed the feat/nft branch from 4c28811 to d4af50e Compare

November 27, 2024 08:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nkramer44 Awaiting requested review from nkramer44 nkramer44 is a code owner

nhartner Awaiting requested review from nhartner nhartner is a code owner

sappenin Awaiting requested review from sappenin sappenin is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet