Skip to content

Fix refresh access token silently failing when using a space delimited string for scope #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: feature/sdk-automation
Choose a base branch
from
Open

Fix refresh access token silently failing when using a space delimited string for scope #132

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82238a3
allow for space delimited scope string
j-osephlong May 23, 2024
d056f42
throw away extra keyword args in update_token rather than throw an "u…
j-osephlong May 23, 2024
593d372
Removed unused param as per requested by @manishT72
j-osephlong Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion xero_python/api_client/oauth2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def can_refresh_access_token(self):
"""
return (
self.refresh_token
and isinstance(self.scope, (list, tuple))
and isinstance(self.scope, (list, tuple, str))
and self.client_id
and self.client_secret
)
Expand Down Expand Up @@ -278,6 +278,7 @@ def update_token(
expires_at=None,
refresh_token=None,
id_token=None,
**kwargs
):
"""
Set new auth2 token details
Expand Down