Skip to content

Commit 8313032

Browse files
author
Vignesh Kennadi
committed
fixed review comments
1 parent 356d43d commit 8313032

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

.rubocop.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ Lint/RequireParentheses:
140140
Enabled: true
141141

142142
Style/RedundantReturn:
143-
Enabled: true
143+
Enabled: false
144144
AllowMultipleReturnValues: true
145145

146146
Style/Semicolon:

lib/xero-ruby/api_client.rb

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ def set_token_set(token_set)
143143
set_access_token(token_set[:access_token]) if token_set[:access_token]
144144
set_id_token(token_set[:id_token]) if token_set[:id_token]
145145

146-
true
146+
return true
147147
end
148148

149149
def set_access_token(access_token)
@@ -160,7 +160,7 @@ def get_client_credentials_token
160160
}
161161
token_set = token_request(data, '/token')
162162

163-
token_set
163+
return token_set
164164
end
165165

166166
def get_token_set_from_callback(params)
@@ -173,7 +173,7 @@ def get_token_set_from_callback(params)
173173

174174
validate_tokens(token_set)
175175
validate_state(params)
176-
token_set
176+
return token_set
177177
end
178178

179179
def validate_tokens(token_set)
@@ -184,14 +184,14 @@ def validate_tokens(token_set)
184184
decode_jwt(access_token) if access_token
185185
decode_jwt(id_token) if id_token
186186
end
187-
true
187+
return true
188188
end
189189

190190
def validate_state(params)
191191
if params['state'] != @state
192192
raise StandardError.new "WARNING: @config.state: #{@state} and OAuth callback state: #{params['state']} do not match!"
193193
end
194-
true
194+
return true
195195
end
196196

197197
def decode_jwt(tkn, verify = true)
@@ -220,15 +220,15 @@ def refresh_token_set(token_set)
220220
grant_type: 'refresh_token',
221221
refresh_token: token_set[:refresh_token]
222222
}
223-
token_request(data, '/token')
223+
return token_request(data, '/token')
224224
end
225225

226226
def revoke_token(token_set)
227227
token_set = token_set.with_indifferent_access
228228
data = {
229229
token: token_set[:refresh_token]
230230
}
231-
token_request(data, '/revocation')
231+
return token_request(data, '/revocation')
232232
end
233233

234234
def token_request(data, path)
@@ -245,7 +245,7 @@ def token_request(data, path)
245245
else
246246
body = {}
247247
end
248-
body
248+
return body
249249
end
250250

251251
# Connection heplers

0 commit comments

Comments
 (0)