Issue #48: Replace deprecated .graph.input/output[0].name with get_global_in/out methods

[rothej]

Added unit tests in tests/util/test_modelwrapper.py. All pre-commit hooks pass, new unit tests verify the helper methods works.

Fixes #48

[rothej]

Using ./run-docker.sh quicktest, results are:

= 1163 passed, 16 skipped, 5 xfailed, 1 xpassed, 77462 warnings in 66.39s (0:01:06) =

All instances of old pattern were replaced with the new pattern in the codebase.

[auphelia]

Hi @rothej,
Thank you for picking up this open issue! This issue dates back to when the modelwrapper (https://github.com/fastmachinelearning/qonnx/blob/main/src/qonnx/core/modelwrapper.py) was still part of FINN. As you can see from the link, it’s now part of qonnx.

Since it is defined in qonnx, the usual workflow is:

• Add the new methods in qonnx.
• Update the FINN commit (https://github.com/Xilinx/finn/blob/dev/fetch-repos.sh) to use the updated version of qonnx.
• Adjust the code accordingly, here you can use what you have already done in your PR.

Would you mind following that structure and first creating a PR to qonnx main that adds those new class methods, instead of adding them on top of modelwrapper inside FINN? I’m sure other users would also appreciate having those new class methods available directly in qonnx.

[rothej]

@auphelia not a problem! I'll go ahead and do that

[rothej]

Pushed a PR for qonnx, once merged I will use that commit to finish fixing this issue. fastmachinelearning/qonnx#225

[rothej]

@auphelia Ive finished this issue! When running run-docker.sh quicktest, there is one error that wasn't there before. Error appears to be because ApplyConfig was removed from qonnx and put into FINN. I updated test_general_transformation.py here in this PR, since I am considering it a part of this qonnx hash update. Just needed to fix imports for that one item. If this is bad practice for this repo please let me know, happy to adjust!

General note: After the updates, ran:

./fetch-repos.sh
pip uninstall qonnx -y
pip install -e deps/qonnx
python -m pytest tests/util/test_modelwrapper.py -v

and tests pass as before.

= 1163 passed, 16 skipped, 5 xfailed, 1 xpassed, 2919 warnings in 65.75s (0:01:05) =