Skip to content

u-boot-xlnx: Avoid breaking compatibility with posix sh #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: langdale-next
Choose a base branch
from

Conversation

ngenetzky-at-appareo
Copy link

NOTE: First time contributor to this repo. Please let me know of any guidelines for contributing that I might not be aware of.


BitBake recipes and class files are primarily written to be shell-agnostic, aiming for compatibility with /bin/sh, which may be dash or other minimal shells instead of bash. Thus, it is advisable to avoid bash-specific syntax (bashisms) to ensure portability and prevent unexpected behavior.

To avoid bashisms in BitBake:

Use POSIX-compliant shell syntax: Stick to standard sh syntax, avoiding constructs like local or [[ ]].

By adhering to these guidelines, one can create more robust and portable BitBake recipes and class files, avoiding issues related to bash dependencies.

@grsandeep85
Copy link
Contributor

Hi @ngenetzky-at-appareo ,

Thanks for the patch, since langdale-next is closed we can consider this for scarthgap release.

@ngenetzky-at-appareo
Copy link
Author

@grsandeep85 , it has already been fixed in the scarthgap branch.

Xilinx 2024.1 choose to use Langdale instead of the Kirkstone LTS. Some of us need to keep building for older versions. I hope you reconsider your branching if you expect others to utilize your BSP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants