Issue RedisLabs#94, test hangs in cluster mode

YaacovHazan · YaacovHazan · commit d2922a4ed459 · 2023-07-09T20:57:57.000+03:00
When a connection is dropped, it needs to empty its pipeline of pending
responses, so in case of reconnection, it won't hang waiting for
old requests.
diff --git a/shard_connection.cpp b/shard_connection.cpp
@@ -289,6 +289,10 @@ void shard_connection::disconnect() {
     }
     m_bev = NULL;
 
+    // empty pipeline
+    while (m_pending_resp)
+        delete pop_req();
+
     m_connection_state = conn_disconnected;
 
     // by default no need to send any setup request

Original file line number	Diff line number	Diff line change
`@@ -289,6 +289,10 @@ void shard_connection::disconnect() {`
`289`	`289`	`}`
`290`	`290`	`m_bev = NULL;`
`291`	`291`
	`292`	`+ // empty pipeline`
	`293`	`+ while (m_pending_resp)`
	`294`	`+ delete pop_req();`
	`295`	`+`
`292`	`296`	`m_connection_state = conn_disconnected;`
`293`	`297`
`294`	`298`	`// by default no need to send any setup request`