Migration to YarnSpinner 3.0#278
Draft
Galdormin wants to merge 2 commits intoYarnSpinnerTool:mainfrom
Draft
Conversation
Contributor
Author
|
With the 3.0, YarnSpinner update its ANTLR version to 4.13.1. However, it seems that the rust version (not updated since 2022) is not enough to update it easily. Some functions are missing. If someone can help me here, I'm not familiar with ANTLR and coulnd't find anything to create those functions. Missing functions in yarnspinerlexer.rs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YarnSpinnerTool/YarnSpinner@v2.5.0...v3.0.0
Compiler
➖ YarnSpinner.Compiler/Builders/DeclarationBuilder.csYarnSpinner.Compiler/GrammarsTests
Runtime
YarnSpinner/CRC32.cs(no need we use a library)