Skip to content

Test and Update CLI Module #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 116 commits into
base: develop
Choose a base branch
from

Conversation

codegen-sh[bot]
Copy link

@codegen-sh codegen-sh bot commented May 17, 2025

Overview

This PR implements comprehensive testing and documentation updates for the CLI module of the Codegen SDK, as requested in issue ZAM-410.

Changes

Test Suite

  • Created a comprehensive test suite for the CLI module, covering:
    • Command argument parsing and validation
    • Authentication and session management
    • API client integration
    • Error handling and user feedback
    • File operations and codemod management

Documentation

  • Updated the CLI module README with detailed command documentation
  • Added README files for the test directories with information on test structure and usage
  • Added docstrings to test functions for better clarity

Organization

  • Organized tests to mirror the structure of the CLI module
  • Created common test fixtures in conftest.py
  • Implemented a test runner script (run_tests.py)

Test Coverage

The implemented tests cover:

  • Core commands (init, login, logout, create, deploy, run, list, config, expert)
  • API client and schemas
  • Authentication and session management
  • Error handling
  • Rich formatting utilities
  • Git utilities
  • Environment handling

Next Steps

  1. Run the test suite to verify all tests pass
  2. Measure and improve test coverage
  3. Add any missing test cases
  4. Fix any issues identified during testing

Related Issues


💻 View my workAbout Codegen

Note

I'm currently writing a description for your pull request. I should be done shortly (<1 minute). Please don't edit the description field until I'm finished, or we may overwrite each other. If I find nothing to write about, I'll delete this message.

Summary by Sourcery

Add a comprehensive testing framework for the Codegen CLI module, update command-line documentation, and modernize project configuration.

Enhancements:

  • Reorganize and mirror CLI module structure in tests with shared fixtures and a dedicated test runner script.
  • Update package.json with explicit packageManager and unified branch configuration.

Build:

  • Add packageManager field and reformat semantic-release branches in package.json.

Documentation:

  • Expand and overhaul CLI README with installation, command reference, and development guidelines.
  • Add README and docstrings for the new test directories and fixtures.

Tests:

  • Introduce extensive unit tests covering CLI commands, API client schemas, authentication/session management, error handling, codemod utilities, rich formatting, environment settings, and Git integration.
  • Add integration tests for end-to-end CLI command workflows.
  • Implement shared fixtures in conftest.py and a run_tests.py script for running and reporting on the CLI test suite.

clee-codegen and others added 30 commits February 26, 2025 23:54
# Motivation

The **Codegen on OSS** package provides a pipeline that:

- **Collects repository URLs** from different sources (e.g., CSV files
or GitHub searches).
- **Parses repositories** using the codegen tool.
- **Profiles performance** and logs metrics for each parsing run.
- **Logs errors** to help pinpoint parsing failures or performance
bottlenecks.

<!-- Why is this change necessary? -->

# Content

<!-- Please include a summary of the change -->
see
[codegen-on-oss/README.md](https://github.com/codegen-sh/codegen-sdk/blob/acfe3dc07b65670af33b977fa1e7bc8627fd714e/codegen-on-oss/README.md)

# Testing

<!-- How was the change tested? -->
`uv run modal run modal_run.py`
No unit tests yet 😿 

# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [x] I have updated the documentation or added new documentation as
needed
Original commit by Tawsif Kamal: Revert "Revert "Adding Schema for Tool Outputs"" (codegen-sh#894)

Reverts codegen-sh#892

---------

Co-authored-by: Rushil Patel <rpatel@codegen.com>
Co-authored-by: rushilpatel0 <171610820+rushilpatel0@users.noreply.github.com>
Original commit by Ellen Agarwal: fix: Workaround for relace not adding newlines (codegen-sh#907)
Copy link

coderabbitai bot commented May 17, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sourcery-ai bot commented May 17, 2025

Reviewer's Guide

This PR introduces a full-fledged test framework for the CLI module—including unit and integration tests—alongside substantial README updates and minor configuration tweaks.

Sequence Diagram for CLI Codemod Creation and Deployment

sequenceDiagram
    actor User
    participant CodegenCLI
    participant CodegenAPI
    participant CloudPlatform

    User->>CodegenCLI: codegen login --token <API_TOKEN>
    activate CodegenCLI
    CodegenCLI->>CodegenAPI: Authenticate User (token)
    activate CodegenAPI
    CodegenAPI-->>CodegenCLI: Auth Success
    deactivate CodegenAPI
    CodegenCLI-->>User: Logged in successfully
    deactivate CodegenCLI

    User->>CodegenCLI: codegen create "MyCodemod" "This is a new codemod."
    activate CodegenCLI
    Note right of CodegenCLI: CLI processes request, generates files locally
    CodegenCLI-->>User: Codemod "MyCodemod" created successfully
    deactivate CodegenCLI

    User->>CodegenCLI: codegen deploy "MyCodemod"
    activate CodegenCLI
    CodegenCLI->>CodegenAPI: Request to deploy "MyCodemod"
    activate CodegenAPI
    CodegenAPI->>CloudPlatform: Deploy "MyCodemod" package
    activate CloudPlatform
    CloudPlatform-->>CodegenAPI: Deployment Acknowledged/In Progress
    deactivate CloudPlatform
    CodegenAPI-->>CodegenCLI: Deployment Status (e.g., In Progress)
    deactivate CodegenAPI
    CodegenCLI-->>User: "MyCodemod" deployment initiated.
    deactivate CodegenCLI
Loading

File-Level Changes

Change Details Files
Expanded CLI documentation
  • Rewrote src/codegen/cli/README.md with installation, usage, and command reference
  • Added detailed test directory READMEs under tests/unit/.../cli and tests/integration/.../cli
  • Inserted docstrings in test modules for clarity
src/codegen/cli/README.md
tests/unit/codegen/cli/README.md
tests/integration/codegen/cli/README.md
Structured and centralized test setup
  • Created conftest.py with shared fixtures for CLI tests
  • Added run_tests.py script to invoke all tests with coverage
tests/unit/codegen/cli/conftest.py
tests/unit/codegen/cli/run_tests.py
Added comprehensive CLI command tests
  • Tested argument parsing, success and failure flows for each command
  • Mocked external dependencies (API client, filesystem, Git) in fixtures
tests/unit/codegen/cli/commands/init/test_init.py
tests/unit/codegen/cli/commands/login/test_login.py
tests/unit/codegen/cli/commands/logout/test_logout.py
tests/unit/codegen/cli/commands/create/test_create.py
tests/unit/codegen/cli/commands/deploy/test_deploy.py
tests/unit/codegen/cli/commands/run/test_run.py
tests/unit/codegen/cli/commands/config/test_config.py
tests/unit/codegen/cli/commands/list/test_list.py
tests/unit/codegen/cli/commands/expert/test_expert.py
Implemented API client and schema validation tests
  • Verified Pydantic schemas for API inputs/outputs
  • Covered HTTP success and error branches in RestAPI
tests/unit/codegen/cli/api/test_schemas.py
tests/unit/codegen/cli/api/test_client.py
tests/unit/codegen/cli/api/test_endpoints.py
Covered authentication, session, and token management
  • Tested CodegenSession initialization and active-session behavior
  • Validated token read/write/clear logic and global environment flags
tests/unit/codegen/cli/auth/test_session.py
tests/unit/codegen/cli/auth/test_token_manager.py
tests/unit/codegen/cli/env/test_global_env.py
Added utility and formatting tests
  • Tested codemod path resolution and file operations
  • Verified UI conversion functions and rich formatting utilities
tests/unit/codegen/cli/utils/test_codemods.py
tests/unit/codegen/cli/codemod/test_convert.py
tests/unit/codegen/cli/rich/test_pretty_print.py
tests/unit/codegen/cli/rich/test_codeblocks.py
Minor configuration update
  • Specified Yarn v4.9.1 as packageManager
  • Formatted release.branches array in package.json
package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

korbit-ai bot commented May 17, 2025

By default, I don't review pull requests opened by bots. If you would like me to review this pull request anyway, you can request a review via the /korbit-review command in a comment.

Copy link
Author

codegen-sh bot commented May 17, 2025

I see a check failed - I'm on it! 🫡

💻 View my work

Copy link
Author

codegen-sh bot commented May 17, 2025

✅ Fixed the failing check in this commit. The issue was a missing import for mock_open in the test file, which was causing the pre-commit and mypy checks to fail. I've added the proper import and pushed the fix to the PR branch.

💻 View my work • React 👍 or 👎

Copy link
Author

codegen-sh bot commented May 17, 2025

I see a check failed - I'm on it! 🫡

💻 View my work

Copy link
Author

codegen-sh bot commented May 17, 2025

✅ Fixed the failing pre-commit and mypy checks in this commit. The issues were:

  1. Import ordering in test files - ruff was expecting imports to be alphabetically ordered
  2. Code formatting - ruff-format was enforcing consistent spacing and line breaks

I've fixed these issues by running the pre-commit hooks on the affected files and committing the changes. The tests should now pass.

💻 View my work • React 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants