test(backend): test routingSvcs error conditions

Author: mrzzy

backend/services/routing.test.ts

@@ -8,13 +8,17 @@ import { describe, expect, test } from "@jest/globals";
 import { CongestionSvc } from "./congestion";
 import { initDB } from "../clients/db";
 import { RoutingSvcFactory } from "../factories/routing";
+import { NotFoundError, ValidationError } from "../error";
 
 describe("RoutingSvc", () => {
   const congestionSvc = new CongestionSvc(initDB());
   // test routing with and without congestion routing
-  const routingSvc = RoutingSvcFactory.create(congestionSvc);
+  const routingSvcs = [
+    RoutingSvcFactory.create(congestionSvc),
+    // RoutingSvcFactory.create(),
+  ];
 
-  test("route() returns routes", async () => {
+  test.each(routingSvcs)("route() returns routes", async (routingSvc) => {
     const routes = await routingSvc.route(
       // NTU nanyang circle
       {
@@ -30,9 +34,48 @@ describe("RoutingSvc", () => {
     expect(routes.length).toBeGreaterThan(0);
   });
 
+  test.each(routingSvcs)(
+    "route() throws NotFoundError on no route",
+    async (routingSvc) => {
+      expect(
+        routingSvc.route(
+          // NTU nanyang circle
+          {
+            longitude: 103.6849923,
+            latitude: 1.3437504,
+          },
+          {
+            longitude: 0,
+            latitude: 0,
+          },
+        ),
+      ).rejects.toThrowError(NotFoundError);
+    },
+  );
+
+  test.each(routingSvcs)(
+    "route() throws ValidationError on bad coordinate",
+    async (routingSvc) => {
+      expect(
+        routingSvc.route(
+          // NTU nanyang circle
+          {
+            longitude: 103.6849923,
+            latitude: 1.3437504,
+          },
+          // changi airport (invalid latitude)
+          {
+            longitude: 103.98847034565972,
+            latitude: -91.0,
+          },
+        ),
+      ).rejects.toThrowError(ValidationError);
+    },
+  );
+
   test("geolookup() returns correct GeoLocation for a given postcode", async () => {
     const postcode = "639798"; // Example postcode for NTU area
-    const location = await routingSvc.geolookup(postcode);
+    const location = await routingSvcs[0].geolookup(postcode);
 
     expect(location).toBeDefined();
     expect(location.latitude).toBeCloseTo(1.3437504, 2);
@@ -42,7 +85,7 @@ describe("RoutingSvc", () => {
   test("geolookup() throws an error for invalid postcode", async () => {
     const invalidPostcode = "000000"; // Example of an invalid postcode
 
-    await expect(routingSvc.geolookup(invalidPostcode)).rejects.toThrow(
+    await expect(routingSvcs[0].geolookup(invalidPostcode)).rejects.toThrow(
       `No location found for postcode: ${invalidPostcode}`,
     );
   });

backend/services/routing.ts

@@ -9,7 +9,7 @@ import * as path from "path";
 import csv from "csv-parser";
 import { components, paths } from "../api";
 import { CongestionSvc } from "./congestion";
-import { NotFoundError } from "../error";
+import { NotFoundError, ValidationError } from "../error";
 
 // routing endpoint url constants
 export const CONGEST_ROUTING_API =
@@ -131,6 +131,10 @@ export class RoutingSvc {
         // no route found
         throw new NotFoundError("No route found between given locations.");
       }
+      if (r["code"] === "InvalidValue") {
+        // no route found
+        throw new ValidationError("Invalid routing parameters given.");
+      }
       throw new Error(
         `OSRM ${url.pathname} request failed with error: ${r["code"]}: ${r["message"]}`,
       );