Skip to content

Commit eeda511

Browse files
committed
Merge remote-tracking branch 'origin/master'
2 parents f71fc70 + ee8e5f1 commit eeda511

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

backend/index.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,9 @@ app.get("/geocode/:postcode", async (req: Request, res: Response) => {
9393

9494
// catchall error handler with json response
9595
// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unused-vars
96-
app.use((err: any, _req: Request, res: Response, _next: NextFunction) => {
97-
console.error(err);
96+
app.use((err: any, req: Request, res: Response, _next: NextFunction) => {
97+
// dump error and on
98+
console.error("Server error: %j Caused by: %j", err, req);
9899
// format error
99100
res.status(err.status || 500).json({
100101
message: err.message,

backend/services/routing.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,10 @@ export class RoutingSvc {
127127

128128
// Handle response failure
129129
if (!response.ok) {
130+
if(r["code"] === "NoRoute") {
131+
// no route found
132+
throw new NotFoundError("Not route found between given locations.");
133+
}
130134
throw new Error(
131135
`OSRM ${url.pathname} request failed with error: ${r["code"]}: ${r["message"]}`,
132136
);

0 commit comments

Comments
 (0)