Fix TypeError in whisper method when API returns JSON string #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add robust error handling for JSON string responses in whisper method - Ensure message is always a dict before assigning status_code - Handle both JSON decode errors and non-dict JSON responses - Add comprehensive unit tests for all error scenarios - Bump version to 2.4.2 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
muhammad-ali-e
approved these changes
Jul 21, 2025
jaseemjaskp
requested changes
Jul 21, 2025
There was a problem hiding this comment.
The error handling improvements are good, but there's a critical bug in the 202 status handling where non-dict responses will cause a KeyError when accessing whisper_hash. The 202 response path requires the whisper_hash field to continue processing, so invalid JSON or non-dict responses should be treated as errors rather than wrapped. Additionally, there's code duplication between error and 202 handling that could be refactored into a helper method.
jaseemjaskp
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixed a TypeError in the
whispermethod that occurred when the API returns a JSON string instead of a JSON object.Why
The existing code assumed that
json.loads(response.text)would always return a dictionary, but it can return a string if the response contains a JSON string value. This caused aTypeError: 'str' object does not support item assignmentwhen trying to assignmessage["status_code"].How
json.loads()calls in the whisper method{"message": str(value)}{"message": response.text}Relevant Docs
Related Issues or PRs
Dependencies Versions / Env Variables
Notes on Testing
Added comprehensive unit tests covering all scenarios:
All tests pass and verify the fix works correctly.
Screenshots
N/A - This is a backend fix
Checklist
I have read and understood the Contribution Guidelines.
🤖 Generated with Claude Code