Improve Highlight Speed

[vector-man]

Expected Behavior

I have a loop adding highlights to a file with AddHighLight(...). It should not take very long.

Actual Behavior

Highlight loop takes quite awhile to add big highlights

Steps to Reproduce the Problem

1. Use hexView.AddHighLight(918010, 65535, false)

[abbaye]

Use CustomBackGround Block for this ... is more suited for this task.

cbb = new CustomBackgroundBlock(918010, 65535, Brushes.Yellow);
hexedit.CustomBackgroundBlockItems.Add(cbb);
hexedit.RefreshView();

[vector-man]

It's still quite slow when working with lots of highlights in files. Lots of slowdown too when scrolling highlighted data.

[abbaye]

Are you using CBB ? Or highlight ?

[abbaye]

Are you tested the ByteFileDiference sample ?

[vector-man]

I haven't tried that sample yet. I just used your solution above, but put it in a loop that adds several highlights (maybe in the thousands), and it's very slow on my PC. It hangs at hexedit.RefreshView() for quite awhile after I add them all. I'm using it in Windows Forms by the way, so I'm not sure if that's part of the issue.

[abbaye]

I don't think winform turn down the speed...

but it's possible to see you code ? It's in a public repo ?

[vector-man]

I can show you the code. I'll try to upload it to a branch soon.

[abbaye]

Good I will check your code... If I can optimize I will do...

I you want you can try to optimize and send a pull request 😄

[sbruyere]

I confirm it's very slow also with very large CustomBackground (> 500 lines) like in this capture.

[abbaye]

I need check for optimise my code. I forgotten this bug in last week 😅

[abbaye]

Completed :)