-
-
Notifications
You must be signed in to change notification settings - Fork 597
Add new rule for public domain license #4127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add new rule for public domain license #4127
Conversation
92d6b35
to
af36c8d
Compare
Now, we detects the correct license expression.
@AyanSinhaMahapatra can you review this PR, simply I add a new rule for public-domain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alok1304 Thanks++ See comments for your consideration
--- | ||
|
||
<licenses> | ||
<license> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a required phrases from license
to public domain
These type of rules often generate false positives based on the other words matched
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alok1304 this is not resolved yet, we need the whole required phrase: <license> <name> public domain
because otherwise this might get wrongly detected to just public domain phrases which might be present in other contexts than software license.
6b0a615
to
e05538d
Compare
e05538d
to
1250647
Compare
Reference: aboutcode-org#3997 Signed-off-by: Alok Kumar <alokkumarjipura9973@gmail.com>
d979a55
to
944496a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments not resolved, see #4127 (comment) for your consideration @alok1304 thanks!
Fixes #3997
Tasks
Run tests locally to check for errors.
Signed-off-by: Alok Kumar alokkumarjipura9973@gmail.com