Skip to content

Conversation

jboulen
Copy link

@jboulen jboulen commented Aug 27, 2025

We have installed your plugin in my institution and it works great. Thank you for sharing this useful plugin.

We have just added a minor patch.

Currently, when you enable the clean filenames option, the characters with diacritics are removed.

E.g., a file named élèves groupe 5.zip becomes lves_groupe_5.zip

Our patch replaces accented letters with their unaccented equivalents.

So, with the example above, the file name becomes eleves_groupe_5.zip

If you are not interested in this change, you can close this PR. No problem. :)

@gergelyrakoczi
Copy link

Dear @jboulen, thank you for this improvement. This makes sense for me; however, first before merging, I will check your change internally.
Cheers,
Gergely

@gergelyrakoczi
Copy link

We have checked your contribution and we like it, and will include the code in the next stable version (probably for Moodle 5.1)
Thank you again! @jboulen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants