Convert characters to ascii before cleaning up file names #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have installed your plugin in my institution and it works great. Thank you for sharing this useful plugin.
We have just added a minor patch.
Currently, when you enable the
clean filenames
option, the characters with diacritics are removed.E.g., a file named
élèves groupe 5.zip
becomeslves_groupe_5.zip
Our patch replaces accented letters with their unaccented equivalents.
So, with the example above, the file name becomes
eleves_groupe_5.zip
If you are not interested in this change, you can close this PR. No problem. :)