Make JSON create atomic #2661
Open
Make JSON create atomic #2661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes processes read an unfinished JSON dump. To avoid dealing with exclusive locks and filesystem support we write the dump to a temporary file and rename it afterwards. This makes the json creation atomic.
|
I'm no C programmer. So i copied from fopen_safe what you are doing in "w" mode and adapted it to the json creation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes processes read an unfinished JSON dump. To avoid dealing with exclusive locks and filesystem support we write the dump to a temporary file and rename it afterwards. This makes the json creation atomic.
Should solve #2660