Skip to content

Added props eventOverlapping#1103

Open
rahul-rayo wants to merge 15 commits into
acro5piano:mainfrom
rahul-rayo:event-overlapping
Open

Added props eventOverlapping#1103
rahul-rayo wants to merge 15 commits into
acro5piano:mainfrom
rahul-rayo:event-overlapping

Conversation

@rahul-rayo
Copy link
Copy Markdown

@rahul-rayo rahul-rayo commented Sep 25, 2024

  • Added props eventOverlapping for events Side by Side instead of overlapping in day and week view.

before
Screenshot 2024-09-25 at 11 10 28 AM

after
Screenshot 2024-09-25 at 11 10 41 AM

- Added exclude Sunday props for if the user wants to remove Sunday in the week and month view.
 - Remove console
 - Added props eventOverlapping for events Side by Side instead of overlapping in day and week view.
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 25, 2024

@rahul-rayo is attempting to deploy a commit to the Kazuya Gosho's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-big-calendar ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 6:34am

@acro5piano
Copy link
Copy Markdown
Owner

@rahul-rayo Thanks! I'll take a look.

@acro5piano
Copy link
Copy Markdown
Owner

This is a breaking change so I'll bump a major version.

@acro5piano
Copy link
Copy Markdown
Owner

@rahul-rayo

Thank you so much for your pull request. I've took a look at the deployed preview and found the events are still overwrapping, although the option is enabled by default - can you provide an example in the storybook for visibility?

image

@rahul-rayo
Copy link
Copy Markdown
Author

Ok @acro5piano if i get time will do.

@acro5piano
Copy link
Copy Markdown
Owner

@rahul-rayo Thank you!

- Customised day-view in added week days in header.
 - Day view in changed like if i click to particular date then automatic change data.
@arisyo13
Copy link
Copy Markdown
Contributor

Any plan to release this PR soon?

@acro5piano
Copy link
Copy Markdown
Owner

@arisyo13 Thanks for flagging this. If you create a complete PR forking from this one, it's welcome.
The biggest blocker is that this PR will breaks the default - which means major version bump.

@nizamozcan
Copy link
Copy Markdown

@arisyo13 Thanks for flagging this. If you create a complete PR forking from this one, it's welcome. The biggest blocker is that this PR will breaks the default - which means major version bump.

Hello,
Is there an update for this Pr?
I am having trouble with conflicting appointments

@acro5piano
Copy link
Copy Markdown
Owner

acro5piano commented Dec 10, 2024

@nizamozcan @Sheena1234
I think @rahul-rayo 's approach is correct, but the default is inverted - I will look into it when I have time, but if you can work on it please update rahul's PR (or create your own).

@NicolasJott
Copy link
Copy Markdown

This would be super helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants