fix(month-mode): remove unnecessary setPage call in onPressCell handler#1168
fix(month-mode): remove unnecessary setPage call in onPressCell handler#1168LeeSeongJinCa wants to merge 1 commit into
Conversation
- Eliminate `calendarRef.current?.setPage(0, { animated: true })` invocation triggered by cell presses in month mode
- Keep the original `onPressCell` logic intact
|
@LeeSeongJinCa is attempting to deploy a commit to the Kazuya Gosho's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi, thank you for your great work on this component! I'm currently using version calendarRef.current?.setPage(0, { animated: true })However, I'm not sure why this call is necessary. In my case, this causes an issue where tapping on a cell from a different month always resets the calendar back to the first page, which disrupts the user experience. Unless this line is required for a specific purpose, I believe it would be helpful to consider removing it in this PR to avoid unexpected behavior. Thanks again, and please let me know if there's any context I might be missing! |
|
Hi @LeeSeongJinCa Thank you for your suggestion! @msvalandro Can you take a look at the proposed change? You updated the code in this commit and both looks reasonable... |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 participants
calendarRef.current?.setPage(0, { animated: true })invocation triggered by cell presses in month modeonPressCelllogic intact