Skip to content

Conversation

salmanmkc
Copy link

No description provided.

salmanmkc and others added 2 commits July 30, 2025 16:11
Upgrade the action to use node 24
@salmanmkc salmanmkc marked this pull request as ready for review August 8, 2025 11:04
@Copilot Copilot AI review requested due to automatic review settings August 8, 2025 11:04
@salmanmkc salmanmkc requested a review from a team as a code owner August 8, 2025 11:04
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the project's Node.js runtime from version 20 to version 24 and adds actionlint configuration to ignore the "invalid runner name" warning for the new node24 runner.

  • Updates Node.js version requirement from 20 to 24 across configuration files
  • Adds actionlint configuration to suppress warnings about the node24 runner
  • Updates linter workflow configuration to disable TypeScript ES validation

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Updates Node.js engine requirement and @types/node dependency version
actionlint.yml Adds new configuration file to ignore node24 runner warnings
action.yml Changes GitHub Action runtime from node20 to node24
.node-version Updates Node.js version specification to 24.4.0
.github/workflows/linter.yml Adds linter configuration and disables TypeScript ES validation

env:
DEFAULT_BRANCH: main
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LINTER_RULES_PATH: .
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed here. The default configuration for super-linter/super-linter is to store linting config files in the .github/linters directory. If you change this here, it will no longer recognize the linter files in that directory. It may be better to move the actionlint.yml into .github/linters in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants