Skip to content

Commit 211f91f

Browse files
committed
remove enterprise code
1 parent 428670f commit 211f91f

File tree

3 files changed

+14
-111
lines changed

3 files changed

+14
-111
lines changed

sqle/api/controller/v1/task.go

Lines changed: 3 additions & 111 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ import (
1111
"net/http"
1212
"net/http/httputil"
1313
"net/url"
14-
"path/filepath"
15-
"regexp"
16-
"sort"
1714
"strconv"
1815
"strings"
1916
"time"
@@ -101,6 +98,7 @@ const (
10198
GitHttpURL = "git_http_url"
10299
GitUserName = "git_user_name"
103100
GitPassword = "git_user_password"
101+
ZIPFileExtension = ".zip"
104102
)
105103

106104
func getSQLFromFile(c echo.Context) (getSQLFromFileResp, error) {
@@ -965,7 +963,7 @@ func AuditTaskGroupV1(c echo.Context) error {
965963
if err != nil {
966964
return controller.JSONBaseErrorReq(c, err)
967965
}
968-
if strings.HasSuffix(fileHeader.Filename, ".zip") && task.FileOrderMethod != "" && task.ExecMode == model.ExecModeSqlFile {
966+
if strings.HasSuffix(fileHeader.Filename, ZIPFileExtension) && task.FileOrderMethod != "" && task.ExecMode == model.ExecModeSqlFile {
969967
sortAuditFiles(fileRecords, task.FileOrderMethod)
970968
}
971969

@@ -1018,79 +1016,6 @@ func AuditTaskGroupV1(c echo.Context) error {
10181016
})
10191017
}
10201018

1021-
type auditFileWithNum struct {
1022-
auditFile *model.AuditFile
1023-
num int
1024-
}
1025-
1026-
type auditFileWithNums []auditFileWithNum
1027-
1028-
func (s auditFileWithNums) Len() int { return len(s) }
1029-
func (s auditFileWithNums) Swap(i, j int) { s[i], s[j] = s[j], s[i] }
1030-
func (s auditFileWithNums) Less(i, j int) bool { return s[i].num < s[j].num }
1031-
1032-
func sortAuditFiles(auditFiles []*model.AuditFile, orderMethod string) {
1033-
var re *regexp.Regexp
1034-
sortedAuditFiles := []*model.AuditFile{}
1035-
1036-
// 索引为0的auditFiles为zip包自身的信息,不参与排序
1037-
sortedAuditFiles = append(sortedAuditFiles, auditFiles[0])
1038-
auditFiles = auditFiles[1:]
1039-
1040-
switch orderMethod {
1041-
case FileNamePrefixNumAscOrder:
1042-
re = regexp.MustCompile(`^\d+`)
1043-
case FileNameSuffixNumAscOrder:
1044-
re = regexp.MustCompile(`\d+$`)
1045-
}
1046-
if re == nil {
1047-
return
1048-
}
1049-
1050-
fileWithNums, invalidOrderFiles := getFileWithNumFromPathsByRe(auditFiles, re)
1051-
fileWithSortNums := auditFileWithNums(fileWithNums)
1052-
sort.Sort(fileWithSortNums)
1053-
1054-
for _, fileWithSortNum := range fileWithSortNums {
1055-
sortedAuditFiles = append(sortedAuditFiles, fileWithSortNum.auditFile)
1056-
}
1057-
sortedAuditFiles = append(sortedAuditFiles, invalidOrderFiles...)
1058-
for i, auditFile := range sortedAuditFiles {
1059-
auditFile.ExecOrder = uint(i)
1060-
}
1061-
}
1062-
1063-
func getFileWithNumFromPathsByRe(auditFiles []*model.AuditFile, re *regexp.Regexp) ([]auditFileWithNum, []*model.AuditFile) {
1064-
invalidOrderFiles := []*model.AuditFile{} // 不符合排序规则的文件路径
1065-
fileWithNums := []auditFileWithNum{}
1066-
1067-
for _, file := range auditFiles {
1068-
filename := getFileNameWithoutExtension(file.FileName)
1069-
match := re.FindString(filename)
1070-
if match == "" {
1071-
invalidOrderFiles = append(invalidOrderFiles, file)
1072-
continue
1073-
}
1074-
num, err := strconv.Atoi(match)
1075-
if err != nil {
1076-
invalidOrderFiles = append(invalidOrderFiles, file)
1077-
log.NewEntry().Errorf("getSortNumsFromFilePaths convert string to number failed, string:%s, err:%v", match, err)
1078-
continue
1079-
}
1080-
fileWithNums = append(fileWithNums, auditFileWithNum{
1081-
auditFile: file,
1082-
num: num,
1083-
})
1084-
}
1085-
return fileWithNums, invalidOrderFiles
1086-
}
1087-
1088-
func getFileNameWithoutExtension(filePath string) string {
1089-
fileName := filepath.Base(filePath)
1090-
ext := filepath.Ext(fileName)
1091-
return strings.TrimSuffix(fileName, ext)
1092-
}
1093-
10941019
func batchCreateFileRecords(s *model.Storage, fileRecords []*model.AuditFile, taskId uint) error {
10951020
// Initialize parentID to 0
10961021
var parentID uint
@@ -1205,27 +1130,6 @@ func ReverseToSqle(c echo.Context, rewriteUrlPath, targetHost string) (err error
12051130
return
12061131
}
12071132

1208-
const (
1209-
FileNamePrefixNumAscOrder = "filename_prefix_num_asc_order"
1210-
FileNameSuffixNumAscOrder = "filename_suffix_num_asc_order"
1211-
)
1212-
1213-
type FileOrderMethod struct {
1214-
Method string
1215-
Desc string
1216-
}
1217-
1218-
var FileOrderMethods = []FileOrderMethod{
1219-
{
1220-
Method: FileNamePrefixNumAscOrder,
1221-
Desc: "文件名前缀数字升序",
1222-
},
1223-
{
1224-
Method: FileNameSuffixNumAscOrder,
1225-
Desc: "文件名后缀数字升序",
1226-
},
1227-
}
1228-
12291133
type SqlFileOrderMethod struct {
12301134
OrderMethod string `json:"order_method"`
12311135
Desc string `json:"desc"`
@@ -1251,17 +1155,5 @@ type GetSqlFileOrderMethodResV1 struct {
12511155
// @Success 200 {object} v1.GetSqlFileOrderMethodResV1
12521156
// @router /v1/tasks/file_order_methods [get]
12531157
func GetSqlFileOrderMethodV1(c echo.Context) error {
1254-
methods := make([]SqlFileOrderMethod, 0, len(FileOrderMethods))
1255-
for _, method := range FileOrderMethods {
1256-
methods = append(methods, SqlFileOrderMethod{
1257-
OrderMethod: method.Method,
1258-
Desc: method.Desc,
1259-
})
1260-
}
1261-
return c.JSON(http.StatusOK, GetSqlFileOrderMethodResV1{
1262-
BaseRes: controller.NewBaseReq(nil),
1263-
Data: SqlFileOrderMethodRes{
1264-
Methods: methods,
1265-
},
1266-
})
1158+
return getSqlFileOrderMethod(c)
12671159
}

sqle/api/controller/v1/task_ce.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,17 @@ package v1
66
import (
77
"github.com/actiontech/sqle/sqle/api/controller"
88
"github.com/actiontech/sqle/sqle/errors"
9+
"github.com/actiontech/sqle/sqle/model"
910

1011
"github.com/labstack/echo/v4"
1112
)
1213

1314
func getTaskAnalysisData(c echo.Context) error {
1415
return controller.JSONBaseErrorReq(c, errors.NewNotSupportGetTaskAnalysisDataErr())
1516
}
17+
18+
func getSqlFileOrderMethod(c echo.Context) error {
19+
return controller.JSONBaseErrorReq(c, errors.NewNotSupportGetSqlFileOrderMethodErr())
20+
}
21+
22+
func sortAuditFiles(auditFiles []*model.AuditFile, orderMethod string) {}

sqle/errors/errors.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,3 +144,7 @@ func NewTaskNoExistOrNoAccessErr() error {
144144
func NewInstanceNoExistErr() error {
145145
return New(DataNotExist, fmt.Errorf("instance is not exist"))
146146
}
147+
148+
func NewNotSupportGetSqlFileOrderMethodErr() error {
149+
return New(EnterpriseEditionFeatures, fmt.Errorf("get sql file order method is enterprise version function"))
150+
}

0 commit comments

Comments
 (0)