Skip to content

Commit 26b6a51

Browse files
committed
fix : Fix nil pointer hazard
1 parent f194b7e commit 26b6a51

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

sqle/model/pipline.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,12 +132,12 @@ func (s *Storage) GetPipelineDetail(projectID ProjectUID, pipelineID uint) (*Pip
132132
}
133133

134134
func (s *Storage) GetPipelineNode(pipelineID uint, nodeID uint) (*PipelineNode, error) {
135-
var node *PipelineNode
135+
var node PipelineNode
136136
err := s.db.Model(PipelineNode{}).Where("pipeline_id = ? AND id = ?", pipelineID, nodeID).First(&node).Error
137137
if err != nil {
138-
return node, errors.New(errors.ConnectStorageError, err)
138+
return nil, errors.New(errors.ConnectStorageError, err)
139139
}
140-
return node, nil
140+
return &node, nil
141141
}
142142

143143
func (s *Storage) GetPipelineNodes(pipelineID uint) ([]*PipelineNode, error) {
@@ -216,7 +216,7 @@ func (s *Storage) UpdatePipeline(pipe *Pipeline, newNodes []*PipelineNode) error
216216
func (s *Storage) UpdatePipelineNode(newNode *PipelineNode) error {
217217
return s.Tx(func(txDB *gorm.DB) error {
218218
// 3 更新节点属性
219-
if err := txDB.Save(&newNode).Error; err != nil {
219+
if err := txDB.Save(newNode).Error; err != nil {
220220
return fmt.Errorf("failed to update pipeline node: %w", err)
221221
}
222222
return nil

0 commit comments

Comments
 (0)