Skip to content

Commit 9337453

Browse files
authored
Merge pull request #2427 from actiontech/fix-issue1532-3
tasks/audits api add file_order_method param
2 parents fa42026 + 49c7fdd commit 9337453

File tree

4 files changed

+22
-4
lines changed

4 files changed

+22
-4
lines changed

sqle/api/controller/v1/task.go

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,11 @@ import (
3434
var ErrTooManyDataSource = errors.New(errors.DataConflict, fmt.Errorf("the number of data sources must be less than %v", MaximumDataSourceNum))
3535

3636
type CreateAuditTaskReqV1 struct {
37-
InstanceName string `json:"instance_name" form:"instance_name" example:"inst_1" valid:"required"`
38-
InstanceSchema string `json:"instance_schema" form:"instance_schema" example:"db1"`
39-
Sql string `json:"sql" form:"sql" example:"alter table tb1 drop columns c1"`
40-
ExecMode string `json:"exec_mode" enums:"sql_file,sqls"`
37+
InstanceName string `json:"instance_name" form:"instance_name" example:"inst_1" valid:"required"`
38+
InstanceSchema string `json:"instance_schema" form:"instance_schema" example:"db1"`
39+
Sql string `json:"sql" form:"sql" example:"alter table tb1 drop columns c1"`
40+
ExecMode string `json:"exec_mode" form:"exec_mode" enums:"sql_file,sqls"`
41+
FileOrderMethod string `json:"file_order_method" form:"file_order_method"`
4142
}
4243

4344
type GetAuditTaskResV1 struct {
@@ -319,12 +320,21 @@ func CreateAndAuditTask(c echo.Context) error {
319320
task.Instance = nil
320321

321322
task.ExecMode = req.ExecMode
323+
task.FileOrderMethod = req.FileOrderMethod
322324
taskGroup := model.TaskGroup{Tasks: []*model.Task{task}}
323325
err = s.Save(&taskGroup)
324326
if err != nil {
325327
return controller.JSONBaseErrorReq(c, err)
326328
}
327329
if len(fileRecords) > 0 {
330+
fileHeader, _, err := getFileHeaderFromContext(c)
331+
if err != nil {
332+
return controller.JSONBaseErrorReq(c, err)
333+
}
334+
if strings.HasSuffix(fileHeader.Filename, ZIPFileExtension) && req.FileOrderMethod != "" && task.ExecMode == model.ExecModeSqlFile {
335+
sortAuditFiles(fileRecords, req.FileOrderMethod)
336+
}
337+
328338
err = batchCreateFileRecords(s, fileRecords, task.ID)
329339
if err != nil {
330340
return controller.JSONBaseErrorReq(c, errors.New(errors.GenericError, fmt.Errorf("save sql file record failed: %v", err)))

sqle/docs/docs.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9002,6 +9002,9 @@ var doc = `{
90029002
"sqls"
90039003
]
90049004
},
9005+
"file_order_method": {
9006+
"type": "string"
9007+
},
90059008
"instance_name": {
90069009
"type": "string",
90079010
"example": "inst_1"

sqle/docs/swagger.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8986,6 +8986,9 @@
89868986
"sqls"
89878987
]
89888988
},
8989+
"file_order_method": {
8990+
"type": "string"
8991+
},
89898992
"instance_name": {
89908993
"type": "string",
89918994
"example": "inst_1"

sqle/docs/swagger.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -482,6 +482,8 @@ definitions:
482482
- sql_file
483483
- sqls
484484
type: string
485+
file_order_method:
486+
type: string
485487
instance_name:
486488
example: inst_1
487489
type: string

0 commit comments

Comments
 (0)