-
Notifications
You must be signed in to change notification settings - Fork 36
Added info command #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added info command #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
terminalgpt/main.py:455
- Consider adding test cases to validate the info command's output, especially to cover scenarios where metadata retrieval fails.
@click.command(help="Information about the TerminalGPT")
adamyodinsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all thank you so much for doing a PR! it is very appreciated 🤟
I have 2 small comments...
And i like the idea of this info command, though i'm not sure there is a place for my name on the info, even though it is really nice for my ego, i don't think it helps to much for the user. maybe we can replace it with the info on the machine use the machine_info command in the config.py file.
Machine:
Version: ...
etc...
What do you think?
| """ | ||
|
|
||
| enc_manager: EncryptionManager = ctx.obj["ENC_MNGR"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need we need to set the encryption manager here. it can be removed.
|
|
||
| enc_manager: EncryptionManager = ctx.obj["ENC_MNGR"] | ||
| printer: Printer = ctx.obj["PRINTER"] | ||
| enc_manager.get_api_key() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, we don't need to set the api key
Description
This pull request adds a new
infocommand to the TerminalGPT project. Theinfocommand provides users with detailed information about the current configuration and settings of the TerminalGPT application. This enhancement aims to improve user experience by allowing users to easily access and review important configuration details.Reviewer Notes:
main.py.Screenshots
Thank you for reviewing this pull request. Your feedback is appreciated!