Merge pull request #6 from addityasingh/as-fix-go-report-card

Fix go report card

Author: addityasingh

LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2024 Pickbox Contributors
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE. 

pkg/admin/server_test.go

@@ -167,7 +167,7 @@ func TestCommand_Validation(t *testing.T) {
 			// For now, we just check that the command can be marshaled
 			_, err := json.Marshal(tt.cmd)
 			assert.NoError(t, err)
-			
+
 			// In a real implementation, we would have a Validate() method
 			// For now, we just check basic field presence
 			if tt.valid {

pkg/monitoring/dashboard_test.go

@@ -11,15 +11,15 @@ import (
 // Test Dashboard creation
 func TestNewDashboard(t *testing.T) {
 	logger := logrus.New()
-	
+
 	// Create a simple monitor (we'll skip the raft dependency for this test)
 	monitor := &Monitor{
 		metrics: NewMetrics("test-node", logger),
 		logger:  logger,
 	}
-	
+
 	dashboard := NewDashboard(monitor, logger)
-	
+
 	require.NotNil(t, dashboard)
 	assert.NotNil(t, dashboard.monitor)
 	assert.Equal(t, logger, dashboard.logger)
@@ -28,39 +28,39 @@ func TestNewDashboard(t *testing.T) {
 // Test Dashboard with nil logger
 func TestNewDashboard_NilLogger(t *testing.T) {
 	logger := logrus.New()
-	
+
 	// Create a simple monitor
 	monitor := &Monitor{
 		metrics: NewMetrics("test-node", logger),
 		logger:  logger,
 	}
-	
+
 	dashboard := NewDashboard(monitor, nil)
-	
+
 	require.NotNil(t, dashboard)
 	assert.Nil(t, dashboard.logger) // NewDashboard doesn't create default logger
 }
 
 // Test Dashboard metrics access
 func TestDashboard_MetricsAccess(t *testing.T) {
 	logger := logrus.New()
-	
+
 	// Create monitor with metrics
 	metrics := NewMetrics("test-node", logger)
 	metrics.IncrementFilesReplicated()
 	metrics.AddBytesReplicated(1024)
-	
+
 	monitor := &Monitor{
 		metrics: metrics,
 		logger:  logger,
 	}
-	
+
 	dashboard := NewDashboard(monitor, logger)
-	
+
 	// Verify dashboard can access metrics through monitor
 	assert.NotNil(t, dashboard.monitor)
 	assert.NotNil(t, dashboard.monitor.metrics)
-	
+
 	// Get metrics and verify they contain expected data
 	nodeMetrics := dashboard.monitor.metrics.GetNodeMetrics()
 	assert.Equal(t, "test-node", nodeMetrics.NodeID)
@@ -71,17 +71,17 @@ func TestDashboard_MetricsAccess(t *testing.T) {
 // Test Dashboard logging with valid logger
 func TestDashboard_Logging(t *testing.T) {
 	logger := logrus.New()
-	
+
 	monitor := &Monitor{
 		metrics: NewMetrics("test-node", logger),
 		logger:  logger,
 	}
-	
+
 	dashboard := NewDashboard(monitor, logger)
-	
+
 	// Verify logger is set
 	assert.Equal(t, logger, dashboard.logger)
-	
+
 	// Test that dashboard can log (no errors should occur)
 	assert.NotPanics(t, func() {
 		dashboard.logger.Info("Test log message")
@@ -91,14 +91,14 @@ func TestDashboard_Logging(t *testing.T) {
 // Test Dashboard structure validation
 func TestDashboard_Structure(t *testing.T) {
 	logger := logrus.New()
-	
+
 	monitor := &Monitor{
 		metrics: NewMetrics("test-node", logger),
 		logger:  logger,
 	}
-	
+
 	dashboard := NewDashboard(monitor, logger)
-	
+
 	// Verify dashboard structure
 	assert.NotNil(t, dashboard)
 	assert.IsType(t, &Dashboard{}, dashboard)
@@ -109,22 +109,22 @@ func TestDashboard_Structure(t *testing.T) {
 // Test Monitor GetMetrics method
 func TestDashboard_MonitorGetMetrics(t *testing.T) {
 	logger := logrus.New()
-	
+
 	metrics := NewMetrics("test-node", logger)
 	metrics.IncrementFilesReplicated()
-	
+
 	monitor := &Monitor{
 		metrics: metrics,
 		logger:  logger,
 	}
-	
+
 	dashboard := NewDashboard(monitor, logger)
-	
+
 	// Test that we can get metrics through the monitor
 	retrievedMetrics := dashboard.monitor.GetMetrics()
 	assert.NotNil(t, retrievedMetrics)
 	assert.Equal(t, metrics, retrievedMetrics)
-	
+
 	// Verify metrics data
 	nodeMetrics := retrievedMetrics.GetNodeMetrics()
 	assert.Equal(t, int64(1), nodeMetrics.FilesReplicated)
@@ -133,7 +133,7 @@ func TestDashboard_MonitorGetMetrics(t *testing.T) {
 // Benchmark dashboard creation
 func BenchmarkNewDashboard(b *testing.B) {
 	logger := logrus.New()
-	
+
 	monitor := &Monitor{
 		metrics: NewMetrics("bench-node", logger),
 		logger:  logger,
@@ -148,13 +148,13 @@ func BenchmarkNewDashboard(b *testing.B) {
 // Benchmark metrics access through dashboard
 func BenchmarkDashboard_MetricsAccess(b *testing.B) {
 	logger := logrus.New()
-	
+
 	metrics := NewMetrics("bench-node", logger)
 	monitor := &Monitor{
 		metrics: metrics,
 		logger:  logger,
 	}
-	
+
 	dashboard := NewDashboard(monitor, logger)
 
 	b.ResetTimer()

pkg/monitoring/metrics_test.go

@@ -1,8 +1,8 @@
 package monitoring
 
 import (
-	"testing"
 	"sync"
+	"testing"
 	"time"
 
 	"github.com/sirupsen/logrus"

pkg/watcher/hash_test.go

@@ -35,18 +35,18 @@ func TestHashContent(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			result := HashContent(tt.data)
-			
+
 			// Verify it's a valid hex string
 			_, err := hex.DecodeString(result)
 			assert.NoError(t, err, "Hash should be valid hex")
-			
+
 			// Verify it's the correct length for SHA-256 (64 hex characters)
 			assert.Equal(t, 64, len(result), "SHA-256 hash should be 64 characters")
-			
+
 			// Verify consistency - same input should produce same hash
 			result2 := HashContent(tt.data)
 			assert.Equal(t, result, result2, "Hash should be consistent")
-			
+
 			// For empty content, verify exact hash
 			if tt.name == "empty_content" {
 				hasher := sha256.New()
@@ -71,12 +71,12 @@ func TestHashContent_Uniqueness(t *testing.T) {
 		[]byte("ab"),
 		[]byte("abc"),
 	}
-	
+
 	hashes := make(map[string][]byte)
-	
+
 	for _, data := range testCases {
 		hash := HashContent(data)
-		
+
 		// Check if we've seen this hash before
 		if existingData, exists := hashes[hash]; exists {
 			// Only fail if the data is actually different (collision)
@@ -85,21 +85,21 @@ func TestHashContent_Uniqueness(t *testing.T) {
 			hashes[hash] = data
 		}
 	}
-	
+
 	// We should have unique hashes for different content
 	assert.Equal(t, len(testCases), len(hashes), "All different content should have unique hashes")
 }
 
 // Test hash stability across multiple calls
 func TestHashContent_Stability(t *testing.T) {
 	testData := []byte("stable test content")
-	
+
 	// Generate hash multiple times
 	hashes := make([]string, 100)
 	for i := 0; i < 100; i++ {
 		hashes[i] = HashContent(testData)
 	}
-	
+
 	// All hashes should be identical
 	firstHash := hashes[0]
 	for i, hash := range hashes {
@@ -114,15 +114,15 @@ func TestHashContent_LargeContent(t *testing.T) {
 	for i := range largeData {
 		largeData[i] = byte(i % 256)
 	}
-	
+
 	hash := HashContent(largeData)
-	
+
 	// Verify it's a valid hash
 	assert.Equal(t, 64, len(hash), "Large content hash should be 64 characters")
-	
+
 	_, err := hex.DecodeString(hash)
 	assert.NoError(t, err, "Large content hash should be valid hex")
-	
+
 	// Verify consistency
 	hash2 := HashContent(largeData)
 	assert.Equal(t, hash, hash2, "Large content hash should be consistent")
@@ -131,7 +131,7 @@ func TestHashContent_LargeContent(t *testing.T) {
 // Benchmark hashing performance
 func BenchmarkHashContent_Small(b *testing.B) {
 	data := []byte("small test content")
-	
+
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
 		HashContent(data)
@@ -144,7 +144,7 @@ func BenchmarkHashContent_Medium(b *testing.B) {
 	for i := range data {
 		data[i] = byte(i % 256)
 	}
-	
+
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
 		HashContent(data)
@@ -157,7 +157,7 @@ func BenchmarkHashContent_Large(b *testing.B) {
 	for i := range data {
 		data[i] = byte(i % 256)
 	}
-	
+
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
 		HashContent(data)