Skip to content

Conversation

shazron
Copy link
Member

@shazron shazron commented Nov 13, 2024

Motivation and Context

Depends on #70 (incorporates the commits from that already)
Fixes #69
⚠️ need to revert and update the @adobe/aio-lib-test-proxy dev dep once the new release is out.

How Has This Been Tested?

  • npm test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6ce8e1c) to head (c0b8063).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          135       139    +4     
  Branches        31        31           
=========================================
+ Hits           135       139    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amulyakashyap09 amulyakashyap09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shazron shazron merged commit 12830bf into master Nov 13, 2024
8 checks passed
@shazron shazron deleted the update-proxy-deps branch November 13, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outdated https-proxy-agent causing issues with apps using http.request

3 participants