Skip to content

Conversation

azun
Copy link

@azun azun commented Sep 26, 2023

Description

OAUTH support for Adobe IMS

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

amuraru and others added 17 commits May 14, 2023 10:13
…topic in a consumer group ADDENDUM

Lower cardinality by not exporting group size for un-stable groups
…ividual metrics

Export as numerical metrics:

- topic_info_partitions_count
- topic_info_replication_factor
- topic_info_min_insync_replicas
- topic_info_retention_ms

Partial fix for redpanda-data#116
Instead report a single global counter metric:
kminio_kafka_consumer_group_info_empty_groups
Filter consumer groups when they are listed to avoid
caching ignored groups.
This is useful to capture the total number of groups in kafka
This is required in containerised environments to properly set
GOMAXPROCS to actual container limits set and not the whole underlying node's CPUs

See:
https://github.com/uber-go/automaxprocs
* Expose max timestamp for each topic and/or partition


Kafka 3.0+ added support to fetch offset with the max timestamp.
This is useful in monitoring the steady progress of producing to a topic/partion
but also to detect very high timestamps in the topic that can stuck topic retention.

This patch adds two new metrics:
- kafka_topic_partition_max_timestamp: for each topic partition reports the max timestamp in that partition
- kafka_topic_max_timestamp: for each topic reports the max timestamp in that topic, computed as the maximum timestamp across partitions


See: 
- https://issues.apache.org/jira/browse/KAFKA-12541
- https://cwiki.apache.org/confluence/display/KAFKA/KIP-734%3A+Improve+AdminClient.listOffsets+to+return+timestamp+and+offset+for+the+record+with+the+largest+timestamp

* Update prometheus/collect_topic_partition_offsets.go
* Filter empty consumer groups

* Collect metrics for a set of CG states

* Update minion/config_consumer_group.go

Co-authored-by: Adrian Muraru <adi.muraru@gmail.com>

* Implement review

* Implement review

* Update the CG state values

---------

Co-authored-by: Adrian Muraru <adi.muraru@gmail.com>
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-ALPINE317-OPENSSL-5776809
- https://snyk.io/vuln/SNYK-ALPINE317-OPENSSL-5776809

Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Copy link

@dobrerazvan dobrerazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants