feat(colorarea): remove modifiers from the API [SWC-1264]#4298
Open
castastrophe wants to merge 1 commit intospectrum-twofrom
Open
feat(colorarea): remove modifiers from the API [SWC-1264]#4298castastrophe wants to merge 1 commit intospectrum-twofrom
castastrophe wants to merge 1 commit intospectrum-twofrom
Conversation
|
| Name | Type |
|---|---|
| @spectrum-css/alertdialog | Major |
| @spectrum-css/asset | Major |
| @spectrum-css/assetcard | Major |
| @spectrum-css/assetlist | Major |
| @spectrum-css/avatar | Major |
| @spectrum-css/badge | Major |
| @spectrum-css/breadcrumb | Major |
| @spectrum-css/colorarea | Major |
| @spectrum-css/divider | Major |
| @spectrum-css/miller | Major |
| @spectrum-css/page | Major |
| @spectrum-css/well | Major |
| @spectrum-css/bundle | Patch |
| @spectrum-css/preview | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
b2ed727 to
d6e5a7f
Compare
Contributor
📚 Branch previewPR #4298 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4298/index.html. |
Contributor
File metricsSummaryTotal size: 1.41 MB*
File change detailscolorarea
colorhandle
colorwheel
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
e7c0f9b to
ccb055e
Compare
14740cb to
857bd63
Compare
01f57de to
b9b3949
Compare
7158cba to
de78ff4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This update removes
--mod-colorarea-*custom property hooks per SWC-1264, see also the RFC for extensible styling. Class selectors and variants remain unchanged; stories were refreshed to match the current API.--mod-colorarea-*custom property hooks.Breaking change: the
--mod-colorarea-*override layer is removed. Consumers should set--spectrum-color-area-*variables directly where customization as needed.Related issue(s)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesValidation steps
spectrum-twobaseline.Regression testing
Validate:
The documentation pages for at least two other components are still loading, including:
If components have been modified, VRTs have been run on this branch: