Skip to content

Commit 2b8a528

Browse files
cdransfcdransf
committed
chore(docs): address feedback
1 parent 20150d0 commit 2b8a528

File tree

4 files changed

+27
-52
lines changed

4 files changed

+27
-52
lines changed

‎migration-roadmap/field-label.md‎

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,6 @@ None found for this component.
117117
<details>
118118
<summary>Diff: Legacy (CSS main) → Spectrum 2 (CSS spectrum-two)</summary>
119119

120-
<details>
121-
<summary>Diff: Legacy (CSS main) → Spectrum 2 (CSS spectrum-two)</summary>
122-
123120
No significant structural changes.
124121

125122
</details>
@@ -134,19 +131,19 @@ No significant structural changes.
134131

135132
### CSS => SWC mapping
136133

137-
| CSS selector | Attribute or slot | Status |
138-
| --------------------------------------------------------------------------------------------- | ------------------------- | --------------- |
139-
| `.spectrum-FieldLabel` | Base element | Implemented |
140-
| `.spectrum-FieldLabel--left` | `side-aligned="start"` | Implemented |
141-
| `.spectrum-FieldLabel--right` | `side-aligned="end"` | Implemented |
142-
| `.spectrum-FieldLabel--sizeL` | `size="l"` | Implemented |
143-
| `.spectrum-FieldLabel--sizeS` | `size="s"` | Implemented |
144-
| `.spectrum-FieldLabel--sizeXL` | `size="xl"` | Implemented |
145-
| `.spectrum-FieldLabel--staticBlack` | `static-color="black"` | Missing from WC (new for S2) |
146-
| `.spectrum-FieldLabel--staticWhite` | `static-color="white"` | Missing from WC (new for S2) |
147-
| `.spectrum-FieldLabel-requiredIcon` | Required icon element | Implemented |
148-
| `.spectrum-FieldLabel.is-disabled` | `disabled` attribute | Implemented |
149-
| `.spectrum-FieldLabel:lang(ja), .spectrum-FieldLabel:lang(ko), .spectrum-FieldLabel:lang(zh)` | Language-specific styling | Implemented |
134+
| CSS selector | Attribute or slot | Status |
135+
| --------------------------------------------------------------------------------------------- | --------------------------------------- | ---------------------------- |
136+
| `.spectrum-FieldLabel` | `:host` | Implemented |
137+
| `.spectrum-FieldLabel--left` | `side-aligned="start"` | Implemented |
138+
| `.spectrum-FieldLabel--right` | `side-aligned="end"` | Implemented |
139+
| `.spectrum-FieldLabel--sizeL` | `size="l"` | Implemented |
140+
| `.spectrum-FieldLabel--sizeS` | `size="s"` | Implemented |
141+
| `.spectrum-FieldLabel--sizeXL` | `size="xl"` | Implemented |
142+
| `.spectrum-FieldLabel--staticBlack` | `static-color="black"` | Missing from WC (new for S2) |
143+
| `.spectrum-FieldLabel--staticWhite` | `static-color="white"` | Missing from WC (new for S2) |
144+
| `.spectrum-FieldLabel-requiredIcon` | Required icon element; `.required-icon` | Implemented |
145+
| `.spectrum-FieldLabel.is-disabled` | `disabled` attribute | Implemented |
146+
| `.spectrum-FieldLabel:lang(ja), .spectrum-FieldLabel:lang(ko), .spectrum-FieldLabel:lang(zh)` | Language-specific styling | Implemented |
150147

151148
## Summary of changes
152149

‎migration-roadmap/help-text.md‎

Lines changed: 12 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -116,29 +116,7 @@ None found for this component.
116116

117117
### HTML Output Comparison
118118

119-
**Legacy (CSS main branch) - Negative variant:**
120-
121-
```html
122-
<div
123-
class="spectrum-HelpText spectrum-HelpText--sizeM spectrum-HelpText--negative"
124-
>
125-
<sp-icon-alert class="spectrum-HelpText-validationIcon"></sp-icon-alert>
126-
<div class="spectrum-HelpText-text">Help text content</div>
127-
</div>
128-
```
129-
130-
**Spectrum 2 (CSS spectrum-two branch) - Negative variant:**
131-
132-
```html
133-
<div
134-
class="spectrum-HelpText spectrum-HelpText--sizeM spectrum-HelpText--negative"
135-
>
136-
<sp-icon-alerttriangle
137-
class="spectrum-HelpText-validationIcon"
138-
></sp-icon-alerttriangle>
139-
<div class="spectrum-HelpText-text">Help text content</div>
140-
</div>
141-
```
119+
No structural differences found.
142120

143121
### Key Changes in HTML Structure
144122

@@ -149,18 +127,18 @@ None found for this component.
149127

150128
### CSS => SWC mapping
151129

152-
| CSS selector | Attribute or slot | Status |
153-
| --------------------------------------------------------------------------------------- | ------------------------- | --------------- |
154-
| `.spectrum-HelpText` | Base element | Implemented |
155-
| `.spectrum-HelpText-text` | Text slot | Implemented |
156-
| `.spectrum-HelpText-validationIcon` | Icon element | Implemented |
130+
| CSS selector | Attribute or slot | Status |
131+
| --------------------------------------------------------------------------------------- | ------------------------- | ------------------------------------ |
132+
| `.spectrum-HelpText` | `:host` | Implemented |
133+
| `.spectrum-HelpText-text` | Text slot | Implemented |
134+
| `.spectrum-HelpText-validationIcon` | Icon element | Implemented |
157135
| `.spectrum-HelpText.is-disabled` | `disabled` attribute | Missing from WC (Implementation gap) |
158-
| `.spectrum-HelpText--negative` | `variant="negative"` | Implemented |
159-
| `.spectrum-HelpText--neutral` | `variant="neutral"` | Implemented |
160-
| `.spectrum-HelpText--sizeL` | `size="l"` | Implemented |
161-
| `.spectrum-HelpText--sizeS` | `size="s"` | Implemented |
162-
| `.spectrum-HelpText--sizeXL` | `size="xl"` | Implemented |
163-
| `.spectrum-HelpText:lang(ja), .spectrum-HelpText:lang(ko), .spectrum-HelpText:lang(zh)` | Language-specific styling | Implemented |
136+
| `.spectrum-HelpText--negative` | `variant="negative"` | Implemented |
137+
| `.spectrum-HelpText--neutral` | `variant="neutral"` | Implemented |
138+
| `.spectrum-HelpText--sizeL` | `size="l"` | Implemented |
139+
| `.spectrum-HelpText--sizeS` | `size="s"` | Implemented |
140+
| `.spectrum-HelpText--sizeXL` | `size="xl"` | Implemented |
141+
| `.spectrum-HelpText:lang(ja), .spectrum-HelpText:lang(ko), .spectrum-HelpText:lang(zh)` | Language-specific styling | Implemented |
164142

165143
## Summary of changes
166144

‎migration-roadmap/infield-button.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ None found for this component.
381381
382382
| CSS selector | Attribute or slot | Status |
383383
| --------------------------------------- | ---------------------- | ---------------------------- |
384-
| `.spectrum-InfieldButton` | Base element | Implemented |
384+
| `.spectrum-InfieldButton` | `:host` | Implemented |
385385
| `.spectrum-InfieldButton--quiet` | `quiet` attribute | Implemented |
386386
| `.spectrum-InfieldButton-fill` | Fill container | Implemented |
387387
| `.spectrum-InfieldButton-icon` | Icon slot | Implemented |

‎migration-roadmap/picker-button.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ None found for this component.
210210

211211
| CSS selector | Attribute or slot | Status |
212212
| ------------------------------------------------------------------ | --------------------- | --------------- |
213-
| `.spectrum-PickerButton` | Base element | Implemented |
213+
| `.spectrum-PickerButton` | `:host` | Implemented |
214214
| `.spectrum-PickerButton--workflowicon .spectrum-PickerButton-fill` | Workflow icon variant | Missing from WC |
215215
| `.spectrum-PickerButton--quiet` | `quiet` attribute | Missing from WC |
216216
| `.spectrum-PickerButton-fill` | Fill container | Implemented |

0 commit comments

Comments
 (0)