Skip to content

Conversation

spdev3000
Copy link
Contributor

@spdev3000 spdev3000 commented May 5, 2025

Description

Extend the focusable selector to avoid retrieving elements with attribute focusable="false" , see: #5431

Related issue(s)

Motivation and context

SVGs with focusable="false" should not be detected.

How has this been tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • [] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@spdev3000 spdev3000 requested a review from a team as a code owner May 5, 2025 17:10
Copy link

changeset-bot bot commented May 5, 2025

⚠️ No Changeset found

Latest commit: d77d610

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@spdev3000 spdev3000 assigned Rajdeepc and unassigned Rajdeepc May 5, 2025
@spdev3000 spdev3000 requested a review from Rajdeepc May 5, 2025 17:11
Copy link
Contributor

github-actions bot commented May 5, 2025

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link
Contributor

github-actions bot commented May 5, 2025

Tachometer results

Currently, no packages are changed by this PR...

@Rajdeepc Rajdeepc changed the title feat(focusables): skip elements with focusable="false" attribute fix: skip elements with focusable="false" attribute May 6, 2025
Copy link
Contributor

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great hardening here, thanks for adding it! Is there any test cases we need to add to ensure it's covered?

@spdev3000
Copy link
Contributor Author

there has been no test cases at all for those selectors, not sure if we want to refactor it again and add tests.

@spdev3000 spdev3000 force-pushed the puchta/focusable-selectors branch from e2be882 to d77d610 Compare May 13, 2025 09:40
Copy link
Contributor

@TarunAdobe TarunAdobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!! I don't see any existing test cases for our focusable-selectors right now so that would be out of scope for this PR.

@Rajdeepc Rajdeepc merged commit 1c12bc0 into main May 13, 2025
24 checks passed
@Rajdeepc Rajdeepc deleted the puchta/focusable-selectors branch May 13, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Extend current focusable selectors to skip elements with focusable="false" attribute
5 participants