-
Notifications
You must be signed in to change notification settings - Fork 233
fix: skip elements with focusable="false" attribute #5432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great hardening here, thanks for adding it! Is there any test cases we need to add to ensure it's covered?
there has been no test cases at all for those selectors, not sure if we want to refactor it again and add tests. |
e2be882
to
d77d610
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!! I don't see any existing test cases for our focusable-selectors right now so that would be out of scope for this PR.
Description
Extend the focusable selector to avoid retrieving elements with attribute
focusable="false"
, see: #5431Related issue(s)
Motivation and context
SVGs with
focusable="false"
should not be detected.How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.