-
Notifications
You must be signed in to change notification settings - Fork 233
docs: barebones component analysis docs #5720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2nd-gen-component-analysis
Are you sure you want to change the base?
docs: barebones component analysis docs #5720
Conversation
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
569c640
to
8d0b2bd
Compare
8d0b2bd
to
e64104c
Compare
- ensure we make changes on the current branch - better diffing instructions
e64104c
to
b67cf32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of little things, but overall, the prompt did a lot of the collecting work for us!
migration-roadmap/status-light.md
Outdated
- `--mod-statuslight-spacing-dot-to-label` | ||
- `--mod-statuslight-spacing-top-to-dot` | ||
- `--mod-statuslight-spacing-top-to-label` | ||
- `--mod-statuslight-subdued-content-color-defaul` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're just missing a "t" in default here.
migration-roadmap/cursor_prompt.md
Outdated
Create a Level 2 heading (`##`) titled "Visual Comparison" | ||
Create a Level 2 Heading: `## Comparison` | ||
|
||
#### 2.1 Visual Comparison |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting this is the place we can remove the visual comparison if we want to remove this from the prompt. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks pretty good! I think all of the things I noted the other day are taken care of! 🥳 There's a teeny typo, but I'm good to approve :)
Description
Creates AI-generated migration documentation to analyze component differences to guide SWC migration to S2, with human vetting. The documentation serves as a bridge between the migrated Spectrum 2 CSS work and the corresponding web components, in order to help engineers understand what needs to be implemented, updated, or aligned between the two systems to guide the development of 2nd generation web components.
This batch is for the barebones components: Asset, Badge, Alert banner, Status light, Progress circle, and Divider
Motivation and context
Related issue(s)
SWC-1202
Screenshots (if appropriate)
Author's checklist
I have added automated tests to cover my changes.I have included a well-written changeset if my change needs to be published.Reviewer's checklist
Includes thoughtfully written changeset if changes suggested includepatch
,minor
, ormajor
featuresAutomated tests cover all use cases and follow best practices for writingValidated on all supported browsersAll VRTs are approved before the author can update Golden HashManual review test cases
Testing Checklist
brown
,cinnamon
,pink
,silver
,turquoise
) and 2 missing style variants (outline
,subtle
)static-color="black"
Documentation Quality
Cross-Reference Accuracy
metadata.json
files