feat(icons-workflow): update workflow icons to the latest version #5735
+195
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 22b8732 The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
rubencarvalho
changed the title
rubencarvalho
force-pushed
the
ruben/update-workflow-icons
branch
from
f54812d to
bce9d00
Compare
rubencarvalho
commented
Sep 19, 2025
There was a problem hiding this comment.
This file does not have direct customer impact - this is only used in our <icons-demo> component inside our docs website and stories.
castastrophe
approved these changes
Sep 19, 2025
| '@spectrum-web-components/icons-workflow': minor | ||
| --- | ||
|
|
||
| - Upgraded to `@adobe/spectrum-css-workflow-icons@5.0.0`. |
There was a problem hiding this comment.
Very nice summary, thanks for all these great details!
| s2: transformIconNames(iconsV2NameList), | ||
| }; | ||
|
|
||
| const iconsListPath = path.join( |
There was a problem hiding this comment.
Would this be a good place to leverage require.resolve with the iconset package name so that when we migrate to the 1st-gen / 2nd-gen set-up, it's able to find it based on package registry instead of path location?
Rajdeepc
approved these changes
Sep 20, 2025
Comment on lines
+5
to
+11
| - Upgraded to `@adobe/spectrum-css-workflow-icons@5.0.0`. | ||
| - Includes changes from previous a4u upstream releases: | ||
| - Added `S2_Icon_HeartFilled_20_N.svg`, updated `S2_Icon_SpeedFast_20_N.svg`. | ||
| - Replaced all 22×20px Cloud State icons with 20px variants. | ||
| - Removed deprecated multi-colored error icon. Added new Cloud State icons (`Disconnected`, `Error`, `InProgress`, `Online`, `Paused`, `Pending`, `SlowConnection`). | ||
| - Updated several other icons (`CloseCaptions`, `CommentHide`, `Community`, etc.). | ||
| - For the full changelog, see: https://github.com/adobe/spectrum-css-workflow-icons/pull/50 |
There was a problem hiding this comment.
Very well documented summary!
| * | ||
| * The function performs the following transformations: | ||
| * 1. Converts PascalCase component names (e.g., "HeartFilled") to lowercase (e.g., "heartfilled") | ||
| * 2. Filters out any names that start with numbers (invalid icon names) |
There was a problem hiding this comment.
It looks like this one wasn’t filtered by the icons team. As we think about scaling icon processing, it might be helpful to handle this filtering upstream so we don’t need to manage it on our end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the workflow icons package to
@adobe/spectrum-css-workflow-icons@5.0.0, which dropped React icons (not relevant to us) and included new latest upstream icon updates.While working on this, I noticed that
iconsList.json- the source of truth for icon filtering in our docs and Storybook - was out of date.I added a script to automatically regenerate it to ensure it stays current.
As a result, you may notice all themes have been affected in the screenshots because of that change.
Motivation and context
Screenshots
The new
heart-filledworkflow icon:Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Verify the addition of the new workflow icon
Device review