Skip to content

Conversation

caseyisonit
Copy link
Contributor

Description

Tachometer github workflow is failing gloriously due to chrome version mismatch

Motivation and context

unbork the workflow

Manual review test cases

  • tachometer workflow runs

@caseyisonit caseyisonit requested a review from a team as a code owner September 23, 2025 20:04
Copy link

changeset-bot bot commented Sep 23, 2025

⚠️ No Changeset found

Latest commit: b426524

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 23, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5750

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link
Member

@cdransf cdransf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! ✨

Copy link
Contributor

Tachometer results

Currently, no packages are changed by this PR...

Copy link
Collaborator

@pfulton pfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this and thanks for pinning these updated versions.

@pfulton pfulton merged commit e649c1c into main Sep 23, 2025
24 checks passed
@pfulton pfulton deleted the caseyisonit/tachometer-fix branch September 23, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants