feat: allow overriding components when extending#709
Open
lougreenwood wants to merge 2 commits intoadopted-ember-addons:masterfrom
Open
feat: allow overriding components when extending#709lougreenwood wants to merge 2 commits intoadopted-ember-addons:masterfrom
lougreenwood wants to merge 2 commits intoadopted-ember-addons:masterfrom
Conversation
# Conflicts: # addon/templates/components/lt-body.hbs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows end users of the add-on to override the components which are used to assemble a table.
Our use case for this is a situation where we have our own in-house
sc-tablecomponent which extendsember-light-table. However, we need to apply additional styling to the sub-components used byember-light-tableusingember-css-modules.For example, by overriding the components, we can create our own
private-lt-headcomponent, and override theheadComponentvalue inlight-table.js:sc-light-table.js (our private table component which overrides
ember-light-tableUsage is then as simple as:
<ScTable ... />and we get ember-light-table with custom sub-components.