Skip to content

Conversation

@Marc-Andrieu
Copy link
Member

Add the promo to the "groups" claim of OIDC's "API" scope in Piwigo's auth client

@Marc-Andrieu Marc-Andrieu self-assigned this Sep 5, 2025
@Marc-Andrieu Marc-Andrieu added authentication ready for review This PR is ready to be reviewed feat New feature or request labels Sep 5, 2025
@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.20%. Comparing base (62704b0) to head (b8b448a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/utils/auth/providers.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
- Coverage   90.21%   90.20%   -0.01%     
==========================================
  Files         229      229              
  Lines       22090    22091       +1     
==========================================
  Hits        19928    19928              
- Misses       2162     2163       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Rotheem Rotheem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to filter promotions being sent with the format 20xx as many users have wrongly formatted ones and each will create a useless group in piwigo

@Marc-Andrieu Marc-Andrieu force-pushed the piwigo/promo branch 2 times, most recently from 12985ec to 68e67e7 Compare September 19, 2025 13:46
@Marc-Andrieu Marc-Andrieu force-pushed the piwigo/promo branch 2 times, most recently from 6a76a58 to 4c90dd0 Compare October 17, 2025 06:45
@Marc-Andrieu Marc-Andrieu merged commit 1388067 into main Nov 21, 2025
8 checks passed
@Marc-Andrieu Marc-Andrieu deleted the piwigo/promo branch November 21, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authentication feat New feature or request ready for review This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants