Skip to content

[ENH] Add whole-series ROCKAD anomaly detector #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pattplatt
Copy link
Contributor

Reference Issues/PRs

Extends on #2326 and replaces #2795 (rebased and updated to current main)

What does this implement/fix? Explain your changes.

Implements whole-series ROCKAD as semi-supervised anomaly detector

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • I've added the estimator/function to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

@aeon-actions-bot aeon-actions-bot bot added anomaly detection Anomaly detection package enhancement New feature, improvement request or other non-bug code enhancement testing Testing related issue or pull request labels Jun 2, 2025
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#6F6E8D}{\textsf{anomaly detection}}$, $\color{#2C2F20}{\textsf{testing}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@pattplatt pattplatt closed this Jun 2, 2025
@pattplatt pattplatt force-pushed the rockad_whole_series branch from fbe0c72 to b9c2a5b Compare June 2, 2025 18:21
@pattplatt pattplatt reopened this Jun 2, 2025
@pattplatt
Copy link
Contributor Author

As I understand it some tests are failing because the series as well as the collection ROCKAD are named the same? Should we give unique names like ROCKAD_Series and ROCKAD_Collection? However this would not fit in the current naming schema... Or can the tests be updated?

@MatthewMiddlehurst
Copy link
Member

Hi, I fixed this in a separate PR. It may be better to rename one of them either way, i.e. SubsequenceROCKAD or something

@pattplatt
Copy link
Contributor Author

Hi, I fixed this in a separate PR. It may be better to rename one of them either way, i.e. SubsequenceROCKAD or something

Ok, should we then just rename the whole-series approach to class WholeSeriesRockad()? File name can stay the same (_rockad)?

@MatthewMiddlehurst
Copy link
Member

I will leave it up to you, I have no preference. I assumed the whole series one was the original.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anomaly detection Anomaly detection package enhancement New feature, improvement request or other non-bug code enhancement testing Testing related issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants