Skip to content

Commit 7ccca95

Browse files
abhishekdwivedi3060abhishekdwivedi3060
committed
Incorporated review comments
1 parent e911ab2 commit 7ccca95

File tree

4 files changed

+27
-27
lines changed

4 files changed

+27
-27
lines changed

‎api/v1/aerospikecluster_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -739,8 +739,8 @@ type PersistentVolumeSpec struct { //nolint:govet // for readability
739739
// Size of volume.
740740
Size resource.Quantity `json:"size"`
741741

742-
// Name for creating PVC for this volume, Name or path should be given
743-
// Name string `json:"name"`
742+
// AccessModes contains the desired access modes the volume should have.
743+
// More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes
744744
// +optional
745745
AccessModes []corev1.PersistentVolumeAccessMode `json:"accessModes,omitempty" protobuf:"bytes,1,rep,name=accessModes,casttype=PersistentVolumeAccessMode"` //nolint:lll // for readability
746746

‎config/crd/bases/asdb.aerospike.com_aerospikeclusters.yaml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6576,8 +6576,8 @@ spec:
65766576
properties:
65776577
accessModes:
65786578
description: |-
6579-
Name for creating PVC for this volume, Name or path should be given
6580-
Name string `json:"name"`
6579+
AccessModes contains the desired access modes the volume should have.
6580+
More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes
65816581
items:
65826582
type: string
65836583
type: array
@@ -8182,8 +8182,8 @@ spec:
81828182
properties:
81838183
accessModes:
81848184
description: |-
8185-
Name for creating PVC for this volume, Name or path should be given
8186-
Name string `json:"name"`
8185+
AccessModes contains the desired access modes the volume should have.
8186+
More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes
81878187
items:
81888188
type: string
81898189
type: array
@@ -8859,8 +8859,8 @@ spec:
88598859
properties:
88608860
accessModes:
88618861
description: |-
8862-
Name for creating PVC for this volume, Name or path should be given
8863-
Name string `json:"name"`
8862+
AccessModes contains the desired access modes the volume should have.
8863+
More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes
88648864
items:
88658865
type: string
88668866
type: array
@@ -15732,8 +15732,8 @@ spec:
1573215732
properties:
1573315733
accessModes:
1573415734
description: |-
15735-
Name for creating PVC for this volume, Name or path should be given
15736-
Name string `json:"name"`
15735+
AccessModes contains the desired access modes the volume should have.
15736+
More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes
1573715737
items:
1573815738
type: string
1573915739
type: array
@@ -17338,8 +17338,8 @@ spec:
1733817338
properties:
1733917339
accessModes:
1734017340
description: |-
17341-
Name for creating PVC for this volume, Name or path should be given
17342-
Name string `json:"name"`
17341+
AccessModes contains the desired access modes the volume should have.
17342+
More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes
1734317343
items:
1734417344
type: string
1734517345
type: array
@@ -18081,8 +18081,8 @@ spec:
1808118081
properties:
1808218082
accessModes:
1808318083
description: |-
18084-
Name for creating PVC for this volume, Name or path should be given
18085-
Name string `json:"name"`
18084+
AccessModes contains the desired access modes the volume should have.
18085+
More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes
1808618086
items:
1808718087
type: string
1808818088
type: array

‎helm-charts/aerospike-kubernetes-operator/crds/customresourcedefinition_aerospikeclusters.asdb.aerospike.com.yaml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6576,8 +6576,8 @@ spec:
65766576
properties:
65776577
accessModes:
65786578
description: |-
6579-
Name for creating PVC for this volume, Name or path should be given
6580-
Name string `json:"name"`
6579+
AccessModes contains the desired access modes the volume should have.
6580+
More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes
65816581
items:
65826582
type: string
65836583
type: array
@@ -8182,8 +8182,8 @@ spec:
81828182
properties:
81838183
accessModes:
81848184
description: |-
8185-
Name for creating PVC for this volume, Name or path should be given
8186-
Name string `json:"name"`
8185+
AccessModes contains the desired access modes the volume should have.
8186+
More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes
81878187
items:
81888188
type: string
81898189
type: array
@@ -8859,8 +8859,8 @@ spec:
88598859
properties:
88608860
accessModes:
88618861
description: |-
8862-
Name for creating PVC for this volume, Name or path should be given
8863-
Name string `json:"name"`
8862+
AccessModes contains the desired access modes the volume should have.
8863+
More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes
88648864
items:
88658865
type: string
88668866
type: array
@@ -15732,8 +15732,8 @@ spec:
1573215732
properties:
1573315733
accessModes:
1573415734
description: |-
15735-
Name for creating PVC for this volume, Name or path should be given
15736-
Name string `json:"name"`
15735+
AccessModes contains the desired access modes the volume should have.
15736+
More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes
1573715737
items:
1573815738
type: string
1573915739
type: array
@@ -17338,8 +17338,8 @@ spec:
1733817338
properties:
1733917339
accessModes:
1734017340
description: |-
17341-
Name for creating PVC for this volume, Name or path should be given
17342-
Name string `json:"name"`
17341+
AccessModes contains the desired access modes the volume should have.
17342+
More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes
1734317343
items:
1734417344
type: string
1734517345
type: array
@@ -18081,8 +18081,8 @@ spec:
1808118081
properties:
1808218082
accessModes:
1808318083
description: |-
18084-
Name for creating PVC for this volume, Name or path should be given
18085-
Name string `json:"name"`
18084+
AccessModes contains the desired access modes the volume should have.
18085+
More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes
1808618086
items:
1808718087
type: string
1808818088
type: array

‎internal/webhook/v1/storage.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ func validateStorage(
219219
) error {
220220
if asdbv1.GetBool(storage.DeleteLocalStorageOnRestart) && len(storage.LocalStorageClasses) == 0 {
221221
return fmt.Errorf(
222-
"deleteLocalStorageOnRestart is set to true, but no local storage classes are defined",
222+
"localStorageClasses cannot be empty if deleteLocalStorageOnRestart is set",
223223
)
224224
}
225225

0 commit comments

Comments
 (0)